Skip to content

Conversation

thaystg
Copy link
Member

@thaystg thaystg commented Dec 12, 2024

pTargetMD can be null here, so checking pTargetMD before accessing it.

Side effect of: #110334

Copy link
Contributor

Tagging subscribers to this area: @tommcdon
See info in area-owners.md if you want to be subscribed.

@thaystg
Copy link
Member Author

thaystg commented Dec 12, 2024

/backport to release/8.0-staging

@thaystg
Copy link
Member Author

thaystg commented Dec 12, 2024

/backport to release/9.0-staging

Copy link
Contributor

Started backporting to release/8.0-staging: https://github.com/dotnet/runtime/actions/runs/12297696742

Copy link
Contributor

Started backporting to release/9.0-staging: https://github.com/dotnet/runtime/actions/runs/12297698622

@thaystg thaystg merged commit 36b2bdd into dotnet:main Dec 12, 2024
88 checks passed
@mikelle-rogers
Copy link
Member

I don't know if that is the needed fix. After investigating last night, I found that before the change, my code went through the first branch in IsTailCallThatReturns. This was because the if statement was if (pTailCallDispatcherMD == NULL). With the fix, there has been an addition to that first if statement and it now reads if (pTailCallDispatcherMD == NULL && type == TailCallFunctionType::TailCallThatReturns), which makes it so my code no longer goes down that first branch.

I will test it, and let you know what happens, and if I think we need to have some more investigation/discussion regarding this issue.

hez2010 pushed a commit to hez2010/runtime that referenced this pull request Dec 14, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Jan 12, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants