Skip to content

Conversation

maraf
Copy link
Member

@maraf maraf commented Nov 12, 2024

Based on #103118. Apparently the one test slipped through, but it should have the same limitation to run only latest TFM test on non-main branches.

Fixes #109653
Fixes #109627

@maraf maraf added arch-wasm WebAssembly architecture area-Infrastructure-mono labels Nov 12, 2024
@maraf maraf added this to the 9.0.x milestone Nov 12, 2024
@maraf maraf self-assigned this Nov 12, 2024
Copy link
Contributor

Tagging subscribers to this area: @akoeplinger, @matouskozak
See info in area-owners.md if you want to be subscribed.

@maraf maraf marked this pull request as ready for review November 12, 2024 17:02
@maraf maraf requested a review from ilonatommy as a code owner November 12, 2024 17:02
@maraf maraf requested a review from lewing November 12, 2024 22:27
@ilonatommy
Copy link
Member

ilonatommy commented Nov 13, 2024

The failures on CI do not look connected: #108937 but there's so many of them that the build analysis failed anyway. The failures include https://helix.dot.net/api/2019-06-17/jobs/2ae0e629-2bbd-4af0-b6c2-ea4fa8f8425d/workitems/Workloads-NoWebcil-ST-Wasm.Build.Tests.NonWasmTemplateBuildTests/console.

@lewing lewing added the Servicing-approved Approved for servicing release label Nov 15, 2024
@lewing
Copy link
Member

lewing commented Nov 15, 2024

tell-mode test changes

@lewing lewing merged commit ba72b6d into dotnet:release/9.0-staging Nov 15, 2024
25 of 26 checks passed
@maraf maraf deleted the WasmDownlevelFixTests branch November 18, 2024 13:08
@jeffschwMSFT jeffschwMSFT modified the milestones: 9.0.x, 9.0.1 Dec 11, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Jan 11, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
arch-wasm WebAssembly architecture area-Infrastructure-mono Servicing-approved Approved for servicing release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants