Skip to content

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Oct 24, 2024

Backport of #109180 to release/9.0

/cc @eiriktsarpalis

Customer Impact

  • Customer reported
  • Found internally

Fixes a customer reported regression from MAUI that manifests as as false positive linker warning when trimming a System.Text.Json application.

Regression

  • Yes
  • No

Introduced by #105032. A linker suppression erroneously used SuppressMessageAttribute instead of UnconditionalSuppressMessageAttribute resulting in the warning being suppressed at build time but not at publish time.

Testing

Manually verified that a warning no longer emanates from the impacted member.

Risk

Low. Makes a trivial change to a linker annotation.

Copy link
Contributor

Tagging subscribers to this area: @dotnet/area-system-text-json, @gregsdennis
See info in area-owners.md if you want to be subscribed.

@eiriktsarpalis eiriktsarpalis self-assigned this Oct 24, 2024
@eiriktsarpalis eiriktsarpalis added this to the 9.0.0 milestone Oct 24, 2024
@eiriktsarpalis eiriktsarpalis added the Servicing-consider Issue for next servicing release review label Oct 24, 2024
@jeffhandley
Copy link
Member

This will be queued up for 9.0 servicing once the release/9.0-staging branch is ready.

Copy link
Contributor

@carlossanlop carlossanlop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@eiriktsarpalis - Please retarget this PR to the release/9.0-staging branch.

You can retarget to that branch by clicking on the Edit button on the top right (next to the PR title) and choosing the release/9.0-staging branch from the dropdown. Important: Please make sure you don't bring any unrelated changes from the release/9.0 branch when retargeting to release/9.0-staging.

@eiriktsarpalis eiriktsarpalis changed the base branch from release/9.0 to release/9.0-staging October 28, 2024 19:23
@eiriktsarpalis
Copy link
Member

Done.

@carlossanlop carlossanlop self-requested a review October 28, 2024 21:17
@jeffhandley jeffhandley changed the title [release/9.0] Replace a few SuppressMessage annotations with UnconditionalSuppressMessage [release/9.0-staging] Replace a few SuppressMessage annotations with UnconditionalSuppressMessage Oct 29, 2024
@jeffhandley
Copy link
Member

@artl93 This is ready for Servicing now

@artl93 artl93 modified the milestones: 9.0.0, 9.0.x Nov 5, 2024
@rbhanda rbhanda added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Nov 5, 2024
@rbhanda rbhanda modified the milestones: 9.0.x, 9.0.1 Nov 5, 2024
@carlossanlop carlossanlop modified the milestones: 9.0.1, 9.0.2 Nov 21, 2024
@jeffhandley jeffhandley requested review from carlossanlop and removed request for carlossanlop December 4, 2024 07:46
@jeffhandley
Copy link
Member

@carlossanlop I just realized this is still sitting open; it needs your approval and then we can merge it for February servicing.

@carlossanlop carlossanlop merged commit 4506441 into release/9.0-staging Jan 13, 2025
85 of 87 checks passed
@carlossanlop carlossanlop deleted the backport/pr-109180-to-release/9.0 branch January 13, 2025 19:45
@github-actions github-actions bot locked and limited conversation to collaborators Feb 13, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-System.Text.Json Servicing-approved Approved for servicing release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants