[Flaky Test] Change request to POST to avoid retry on server Shutdown #105035
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
|
/azp run runtime-libraries-coreclr outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run runtime |
|
Azure Pipelines successfully started running 1 pipeline(s). |
rokonec
changed the title
rokonec
changed the title
This was referenced Jul 17, 2024
|
/azp run runtime-libraries-coreclr outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
ManickaP
approved these changes
Jul 18, 2024
|
/ba-g Unrelated failures. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #96407
Context
I am not sure how was this test runs in past, as the code https://github.com/rokonec/runtime/blob/01fb6bdee56cbbceb0fa9f2f890b0bcb4bdacb6e/src/libraries/System.Net.Http/src/System/Net/Http/SocketsHttpHandler/HttpConnection.cs#L654-L657
intent to retry when server side shut downs its side for idle timeout or other reason.
This test has timeouted on any OS during my testing.
Originally it was belived this test was flaky on OSX only, but it was present on other OSes, just less frequently.
Changes made
Test code only changes
Test request changed from GET to POST-with-content-body to avoid implicit retry logic.