Do not fold exported UnmanagedCallersOnly symbols #103884
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes issue that was ran into at https://github.com/MichalStrehovsky/rt-sz/actions/runs/9611846921.
ghost
added
the
|
Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas |
jkotas
reviewed
Jun 24, 2024
| </ItemGroup> | ||
|
|
||
| <ItemGroup> | ||
| <IlcArg Include="--export-unmanaged-entrypoints" /> |
There was a problem hiding this comment.
Set IlcExportUnmanagedEntrypoints property to true instead of using the command line option directly?
It is what the other tests do:
There was a problem hiding this comment.
The reason I did it this way is because we're not really testing the thing is exported, just making sure linker doesn't error out.
If I use the property and we rename or delete the property, the test silently stops testing this. If it stays command line argument, the test build will fail if we ever rename or delete it.
But I can change it if you think it's not a risk worth mitigating.
am11
reviewed
Jun 24, 2024
jkotas
approved these changes
Jun 24, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue that was ran into at https://github.com/MichalStrehovsky/rt-sz/actions/runs/9611846921.
Cc @Sergio0694 @dotnet/ilc-contrib