- 
                Notifications
    
You must be signed in to change notification settings  - Fork 5.2k
 
[mono][wasm] Refactor mono_fixup_symbol_name #101681
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Merged
      
      
            mkhamoyan
  merged 12 commits into
  dotnet:main
from
mkhamoyan:refactor_fixup_symbol_function
  
      
      
   
  May 9, 2024 
      
    
                
     Merged
            
            [mono][wasm] Refactor mono_fixup_symbol_name #101681
                    mkhamoyan
  merged 12 commits into
  dotnet:main
from
mkhamoyan:refactor_fixup_symbol_function
  
      
      
   
  May 9, 2024 
              
            Conversation
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
    | 
           Tagging subscribers to this area:  | 
    
              
                    lambdageek
  
              
              requested changes
              
                  
                    Apr 29, 2024 
                  
              
              
            
            
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- important Don't return the address of a stack-allocated temporary.
 - Avoid C standard string manipulation functions that don't take a buffer length (like 
strcpy). Consider usingGStringfrom eglib instead. - Remove some of the duplicated logic about which characters are copied, which ones replaced by 
_and which ones are encoded in hex. 
              
                    mkhamoyan
  
              
              commented
              
                  
                    Apr 29, 2024 
                  
              
              
            
            
              
                    lambdageek
  
              
              approved these changes
              
                  
                    Apr 29, 2024 
                  
              
              
            
            
              
                    lambdageek
  
              
              reviewed
              
                  
                    Apr 29, 2024 
                  
              
              
            
            
  This was referenced May 6, 2024 
      
      
  
  Closed
  
              
                    mkhamoyan
  
              
              commented
              
                  
                    May 6, 2024 
                  
              
              
            
            
              
                    akoeplinger
  
              
              reviewed
              
                  
                    May 7, 2024 
                  
              
              
            
            
              
                    akoeplinger
  
              
              approved these changes
              
                  
                    May 8, 2024 
                  
              
              
            
            
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One comment, LGTM otherwise
  This was referenced May 9, 2024 
      
  
  Closed
  
      
  
  Closed
  
    
  rolfbjarne 
      added a commit
        to dotnet/macios
      that referenced
      this pull request
    
      May 27, 2024 
    
    
  
    
  rolfbjarne 
      added a commit
        to dotnet/macios
      that referenced
      this pull request
    
      May 27, 2024 
    
    
  
    
  Ruihan-Yin 
      pushed a commit
        to Ruihan-Yin/runtime
      that referenced
      this pull request
    
      May 30, 2024 
    
    
      
  
    
      
    
  
Refactor mono_fixup_symbol_name, apply @lambdageek's feedback
  
      Sign up for free
      to subscribe to this conversation on GitHub.
      Already have an account?
      Sign in.
  
      
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
This PR is a follow up for #101106