System.Threading.RateLimiting consistent naming for permit count

[AliKhalili]

In System.Threading.RateLimiting library, its authors consider permit count as the number of permits that client can request.

/// <summary>
/// Method that <see cref="RateLimiter"/> implementations implement for <see cref="AttemptAcquire"/>.
/// </summary>
/// <param name="permitCount">Number of permits to try and acquire.</param>
/// <returns></returns>
protected abstract RateLimitLease AttemptAcquireCore(int permitCount);

but the FixedWindowRateLimiter and SlidingWindowRateLimiter classes are using requestCount for naming permit count which is breaking the naming consistency and also loses the inherited comment for permitCount parameter.

/// <inheritdoc/>
protected override RateLimitLease AttemptAcquireCore(int requestCount)

I would suggest it is more clear and consistent if it uses permitCount instead of requestCount all over the implementation.

Tagging subscribers to this area: @mangod9
See info in area-owners.md if you want to be subscribed.

Issue Details

---

In System.Threading.RateLimiting library, its authors consider permit count as the number of permits that client can request.

/// <summary>
/// Method that <see cref="RateLimiter"/> implementations implement for <see cref="AttemptAcquire"/>.
/// </summary>
/// <param name="permitCount">Number of permits to try and acquire.</param>
/// <returns></returns>
protected abstract RateLimitLease AttemptAcquireCore(int permitCount);

but the FixedWindowRateLimiter and SlidingWindowRateLimiter classes are using requestCount for naming permit count which is breaking the naming consistency and also loses the inherited comment for permitCount parameter.

/// <inheritdoc/>
protected override RateLimitLease AttemptAcquireCore(int requestCount)

I would suggest it is more clear and consistent if it uses permitCount instead of requestCount all over the implementation.

Author:	AliKhalili
Assignees:	-
Labels:	area-System.Threading
Milestone:	-

[BrennanConroy]

Fixed via #76558