Source build fixes #67747
Merged
Source build fixes #67747
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The source build produced from our official build needs to include both the net7.0 and net8.0 packages. Those packages feed into the soucre build legs of other repos and they can be targeting either net7.0 or net8.0.
ghost
added
the
untriaged
|
@dotnet/roslyn-compiler PTAL |
333fred
approved these changes
Apr 11, 2023
added 2 commits
April 11, 2023 13:50
Work around a bug in the public API analyzer dotnet/roslyn-analyzers#6059
333fred
approved these changes
Apr 11, 2023
jjonescz
reviewed
Apr 12, 2023
| targeting NetCurrent or NetPrevious hence we must produce both. | ||
| - Source build the product: this is the all up build of the product which needs only NetCurrent | ||
| --> | ||
| <SourceBuildTargetFrameworks></SourceBuildTargetFrameworks> |
There was a problem hiding this comment.
Nit: seems like this empty property is not needed? (Won't it prevent someone doing msbuild /p:SourceBuildTargetFrameworks=customvalue if they want to experiment locally?)
There was a problem hiding this comment.
Won't it prevent someone doing msbuild /p:SourceBuildTargetFrameworks=customvalue
It won't prevent that because /p: wins all the time as it's a global property. Essentially it overrides whatever is in the project file and becomes a readonly property of build. It's very counterintuitive. The only way to get around this is to use TreatAsLocalProperty. Generally though that feature is not used very often, at least in our builds
|
this is still blocking the sdk change |
jjonescz
approved these changes
Apr 13, 2023
jaredpar
removed
the
untriaged
rainersigwald
added a commit
to dotnet/msbuild
that referenced
this pull request
Apr 21, 2023
As of dotnet/roslyn#67747, the name is just netcore.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The source build produced from our official build needs to include both the net7.0 and net8.0 packages. Those packages feed into the soucre build legs of other repos and they can be targeting either net7.0 or net8.0.