Start Razor Language Server when new Razor LSP editor opens. #1487
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,75 @@ | ||
| using System; | ||
| using System.Collections.Generic; | ||
| using System.ComponentModel.Composition; | ||
| using System.Diagnostics; | ||
| using System.IO; | ||
| using System.Threading; | ||
| using System.Threading.Tasks; | ||
| using Microsoft.VisualStudio.LanguageServer.Client; | ||
| using Microsoft.VisualStudio.Threading; | ||
| using Microsoft.VisualStudio.Utilities; | ||
|
|
||
| namespace Microsoft.VisualStudio.LanguageServerClient.Razor | ||
| { | ||
| [Export(typeof(ILanguageClient))] | ||
| [ContentType(RazorLSPContentTypeDefinition.Name)] | ||
| internal class RazorLanguageServerClient : ILanguageClient | ||
| { | ||
| public string Name => "Razor Language Server Client"; | ||
|
|
||
| public IEnumerable<string> ConfigurationSections => null; | ||
|
|
||
| public object InitializationOptions => null; | ||
|
|
||
| public IEnumerable<string> FilesToWatch => null; | ||
|
|
||
| public event AsyncEventHandler<EventArgs> StartAsync; | ||
| public event AsyncEventHandler<EventArgs> StopAsync | ||
| { | ||
| add { } | ||
| remove { } | ||
| } | ||
|
|
||
| public async Task<Connection> ActivateAsync(CancellationToken token) | ||
| { | ||
| await Task.Yield(); | ||
|
|
||
| var currentAssembly = typeof(RazorLanguageServerClient).Assembly; | ||
| var currentAssemblyLocation = currentAssembly.Location; | ||
| var extensionDirectory = Path.GetDirectoryName(currentAssemblyLocation); | ||
| var languageServerPath = Path.Combine(extensionDirectory, "LanguageServer", "rzls.exe"); | ||
| var info = new ProcessStartInfo(); | ||
| info.FileName = languageServerPath; | ||
|
Contributor
There was a problem hiding this comment. Possible nit: var info = new ProcessStartInfo{
info.FileName = languageServerPath,
// ...
} |
||
| info.Arguments = "-lsp --logLevel Trace"; | ||
| info.RedirectStandardInput = true; | ||
| info.RedirectStandardOutput = true; | ||
| info.UseShellExecute = false; | ||
| info.CreateNoWindow = true; | ||
|
|
||
| Process process = new Process(); | ||
| process.StartInfo = info; | ||
|
|
||
| if (process.Start()) | ||
| { | ||
| return new Connection(process.StandardOutput.BaseStream, process.StandardInput.BaseStream); | ||
| } | ||
|
|
||
| return null; | ||
| } | ||
|
|
||
| public async Task OnLoadedAsync() | ||
| { | ||
| await StartAsync.InvokeAsync(this, EventArgs.Empty); | ||
| } | ||
|
|
||
| public Task OnServerInitializeFailedAsync(Exception e) | ||
| { | ||
| return Task.CompletedTask; | ||
|
Contributor
There was a problem hiding this comment. All three of these functions strike me as in need of diagnostic logging (but especially
Author
There was a problem hiding this comment. You're definitely right. We'll expand on the implementation of this class in the coming months. For now it's just basic boiler plate to get the ball rolling 😄 |
||
| } | ||
|
|
||
| public Task OnServerInitializedAsync() | ||
| { | ||
| return Task.CompletedTask; | ||
| } | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is the add/remove explicitly defined here but implicitly defined for
StartAsync?Also, I don't see anywhere that
StopAsyncis actually called? I suspect I misunderstand the workflow of ILanguageClient. Could you go into the expected flow a bit?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
StartAsyncis called when we actually start the language server but we don't actually take control of stopping the language server currently. We rely on the ILanguageClient infrastructure to stop us. The gist here is that our ILanguageClient is very "dumb" currently. It's just the boiler plate to start a basic language server and then I plan to fill it out later as we flesh it all out more.