MicroBenchmarks build failing with error `NU1510`

[xtqqczze]

dotnet run -c Release -f net9.0 --project src/benchmarks/micro --list tree --filter 'System.Threading*'

~/performance/src/benchmarks/micro/MicroBenchmarks.csproj : error NU1510: Warning As Error: PackageReference System.Diagnostics.DiagnosticSource will not be pruned. Consider removing this package from your dependencies, as it is likely unnecessary.
~/performance/src/benchmarks/micro/MicroBenchmarks.csproj : error NU1510: Warning As Error: PackageReference System.Threading.Channels will not be pruned. Consider removing this package from your dependencies, as it is likely unnecessary.

cc: @nkolev92

[prozolic]

I also encounter NU1510 warnings in my environment. When I exclude net10.0 from TargetFrameworks, it succeeds, so it seems that the presence or absence of net10.0 is related to the issue.

-<TargetFrameworks Condition="'$(TargetFrameworks)' == '' AND '$(OS)' == 'Windows_NT'">net462;net6.0;net7.0;net8.0;net9.0;net10.0</TargetFrameworks>
+<TargetFrameworks Condition="'$(TargetFrameworks)' == '' AND '$(OS)' == 'Windows_NT'">net462;net6.0;net7.0;net8.0;net9.0</TargetFrameworks>

I think the following would be related content.

https://learn.microsoft.com/en-us/nuget/reference/errors-and-warnings/nu1510

Note

In order to allow for easier adoption of the PrunePackageReference feature, this warning is raised by default when a project targets the .NET 10 framework or newer.

https://learn.microsoft.com/en-us/dotnet/core/compatibility/sdk/10.0/nu1510-pruned-references

[xtqqczze]

I'm still getting NU1510 warnings even after the changes in #4977.

[nkolev92]

What's your SDK version?

If this is P5 or newer, please following the instructions in the warning and remove the package reference.
It is provided by the platform

[xtqqczze]

What's your SDK version?

If this is P5 or newer, please following the instructions in the warning and remove the package reference. It is provided by the platform

@nkolev92 10.0.100-rc.1.25420.111 is specified in global.json

The package reference is only included for versions before 10.0:

performance/src/benchmarks/micro/MicroBenchmarks.csproj

Lines 99 to 103 in 33a9145

	<ItemGroup Condition="'$(TargetFrameworkIdentifier)' == '.NETCoreApp' And '$(_TargetFrameworkVersionWithoutV)' &lt; '10.0'">
	<PackageReference Include="System.Diagnostics.DiagnosticSource" Version="$(SystemVersion)" />
	<PackageReference Include="System.IO.Pipelines" Version="$(SystemVersion)" />
	<PackageReference Include="System.Threading.Channels" Version="$(SystemVersion)" />
	</ItemGroup>

I've tried modernising the MSBuild conditions in #4977 but still getting the error.

[LoopedBard3]

As a work around while we take a look, setting either of these environment variables before running should work around the error:
(Powershell examples) $env:NoWarn="NU1510" or $env:PERFLAB_TARGET_FRAMEWORKS="net9.0" (or whatever framework you are building for). In the CI we use PERFLAB_TARGET_FRAMEWORKS set to the version we are testing which is why we are not seeing this in CI.

[caaavik-msft]

#4982 resolves this issue. The warning is valid and the change resolves it without suppressing it. Those packages are provided in the SDK by all the .NET Core SDKs that we support, so just deleting that ItemGroup is all that was needed to be done.