Skip to content

Readd Microsoft.NET.Test.Sdk package reference #4014

@LoopedBard3

Description

@LoopedBard3

We recently removed the Microsoft.NET.Test.Sdk package reference in order to mitigate a MonoAOT build error occurring because of it: #4008. This removal seems to now be causing an error in WasmAOT builds (local test run):

[2024/02/28 19:16:16][INFO]   [60/166] System.Collections.NonGeneric.dll -> System.Collections.NonGeneric.dll.bc
[2024/02/28 19:16:16][INFO] Build FAILED.
[2024/02/28 19:16:16][INFO] CSC : warning CS8002: Referenced assembly 'MicroBenchmarks, Version=42.42.42.42, Culture=neutral, PublicKeyToken=null' does not have a strong name. [/home/pbibus/performance/artifacts/bin/MicroBenchmarks/Release/net9.0/Job-ZIZMTN/BenchmarkDotNet.Autogenerated.csproj]
[2024/02/28 19:16:16][INFO] /home/pbibus/performance/scripts/runtime-testing-artifacts/dotnet/packs/Microsoft.NET.Runtime.WebAssembly.Sdk/9.0.0-preview.3.24128.2/Sdk/WasmApp.Common.targets(681,5): error : Precompiling failed for /home/pbibus/performance/artifacts/bin/MicroBenchmarks/Release/net9.0/Job-ZIZMTN/obj/Release/net9.0/wasm/for-publish/aot-in/Microsoft.VisualStudio.TestPlatform.Common.dll with exit code 1. [/home/pbibus/performance/artifacts/bin/MicroBenchmarks/Release/net9.0/Job-ZIZMTN/BenchmarkDotNet.Autogenerated.csproj]
[2024/02/28 19:16:16][INFO] /home/pbibus/performance/scripts/runtime-testing-artifacts/dotnet/packs/Microsoft.NET.Runtime.WebAssembly.Sdk/9.0.0-preview.3.24128.2/Sdk/WasmApp.Common.targets(681,5): error : Failed to load custom attributes from method void Microsoft.VisualStudio.TestPlatform.Common.Filtering.Condition:ThrownFormatExceptionForInvalidCondition (string) due to Could not resolve type with token 010000a0 from typeref (expected class 'System.Diagnostics.CodeAnalysis.DoesNotReturnAttribute' in assembly 'Microsoft.TestPlatform.CoreUtilities, Version=15.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a') assembly:Microsoft.TestPlatform.CoreUtilities, Version=15.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a type:System.Diagnostics.CodeAnalysis.DoesNotReturnAttribute member:(null) [/home/pbibus/performance/artifacts/bin/MicroBenchmarks/Release/net9.0/Job-ZIZMTN/BenchmarkDotNet.Autogenerated.csproj]
[2024/02/28 19:16:16][INFO] /home/pbibus/performance/scripts/runtime-testing-artifacts/dotnet/packs/Microsoft.NET.Runtime.WebAssembly.Sdk/9.0.0-preview.3.24128.2/Sdk/WasmApp.Common.targets(681,5): error : FullAOT cannot continue if there are loader errors. [/home/pbibus/performance/artifacts/bin/MicroBenchmarks/Release/net9.0/Job-ZIZMTN/BenchmarkDotNet.Autogenerated.csproj]
[2024/02/28 19:16:16][INFO] /home/pbibus/performance/scripts/runtime-testing-artifacts/dotnet/packs/Microsoft.NET.Runtime.WebAssembly.Sdk/9.0.0-preview.3.24128.2/Sdk/WasmApp.Common.targets(681,5): error : Mono Ahead of Time compiler - compiling assembly /home/pbibus/performance/artifacts/bin/MicroBenchmarks/Release/net9.0/Job-ZIZMTN/obj/Release/net9.0/wasm/for-publish/aot-in/Microsoft.VisualStudio.TestPlatform.Common.dll [/home/pbibus/performance/artifacts/bin/MicroBenchmarks/Release/net9.0/Job-ZIZMTN/BenchmarkDotNet.Autogenerated.csproj]
[2024/02/28 19:16:16][INFO] /home/pbibus/performance/scripts/runtime-testing-artifacts/dotnet/packs/Microsoft.NET.Runtime.WebAssembly.Sdk/9.0.0-preview.3.24128.2/Sdk/WasmApp.Common.targets(681,5): error : Can't find custom attr constructor image: /home/pbibus/performance/artifacts/bin/MicroBenchmarks/Release/net9.0/Job-ZIZMTN/obj/Release/net9.0/wasm/for-publish/aot-in/Microsoft.VisualStudio.TestPlatform.Common.dll mtoken: 0x0a00002a due to: Could not resolve type with token 010000a0 from typeref (expected class 'System.Diagnostics.CodeAnalysis.DoesNotReturnAttribute' in assembly 'Microsoft.TestPlatform.CoreUtilities, Version=15.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a') assembly:Microsoft.TestPlatform.CoreUtilities, Version=15.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a type:System.Diagnostics.CodeAnalysis.DoesNotReturnAttribute member:(null) [/home/pbibus/performance/artifacts/bin/MicroBenchmarks/Release/net9.0/Job-ZIZMTN/BenchmarkDotNet.Autogenerated.csproj]

WasmAOT is also currently broken by something else dotnet/runtime#98960, so I think we should keep the removal for now, but we need to figure out how to add it back in and have everything work to both fix WasmAOT and support the BDN Test Adapter in our repo.

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions