- 
                Notifications
    You must be signed in to change notification settings 
- Fork 1.9k
Modernize Essentials Namespaces #5562
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| /azp run | 
| Azure Pipelines successfully started running 2 pipeline(s). | 
| After some manual extraction of the patch and find & replace it looks like the namespace changes can be summarized as follows (different types went in different ways). I think that makes sense. /cc @bartonjs -namespace Microsoft.Maui.Devices;
-namespace Microsoft.Maui.Essentials
-namespace Microsoft.Maui.Essentials.Implementations
+namespace Microsoft.Maui.Accessibility
+namespace Microsoft.Maui.ApplicationModel
+namespace Microsoft.Maui.ApplicationModel.Communication
+namespace Microsoft.Maui.ApplicationModel.DataTransfer
+namespace Microsoft.Maui.Authentication
+namespace Microsoft.Maui.Devices
+namespace Microsoft.Maui.Devices.Sensors
+namespace Microsoft.Maui.Devices;
+namespace Microsoft.Maui.Hosting
+namespace Microsoft.Maui.Media
+namespace Microsoft.Maui.Networking
+namespace Microsoft.Maui.Storage | 
| Seems generally reasonable to me | 
| Hi @mattleibow Why this or anyother don't have the summy included. If anyone don't know from scrach and come to this then how he can get any idea aobut this what's the purpose of using SemanticScreenReader.Announce(CounterLabel.Text); | 
| Could you open a new issue on that? Your comments will get lost on closed issues. | 
| Hello all, in which namespace is the method to create a new contact? In the past there was a method like "Microsoft.Maui.Essentials.Contacts.AddContactAsync" but i cant find this one in the new namespaces?! | 
| This PR is quite old and all comments will probably get lost. I just saw this as I was browsing my notifications. 
 | 
Description of Change
This PR is based on part of a discussion where it sort of feels the Essentials API doesn't really fit with Maui right now. It is just a blob of stuff that things use, but in fact it is a large part of what makes Maui a real framework.
Xamarin.Forms and now .NET MAUI is cool and has buttons and text boxes, but that is just a part of making apps. Apps require things like sharing, file picking, sensors and more. We created Xamarin.Essentials as a nice small package that had all the tools you would need.
This PR is to basically morph the namespaces so that it makes separation of the types and potentially splitting the dll into smaller parts. Not sure if that is a good or bad things right now, but this makes the namespaces fit more with an app framework.
New API