Skip to content

Conversation

@Eilon
Copy link
Contributor

@Eilon Eilon commented Jun 4, 2021

In dotnet/aspnetcore#33125 I introduced new abstractions that allow sharing WebView2 code between WPF/WinForms and .NET MAUI. Eventually MAUI will use those abstractions, but we can't reference them from MAUI until Preview 6. So for now I've copied the abstractions from ASP.NET Core into MAUI so that the MAUI code can use the updated pattern. Then, in Preview 6, we can update the reference to ASP.NET Core and delete all the "SharedSource" files (that are 100% exact copies from ASP.NET Core).

So, no functional changes at all in this PR. Just refactoring code for .NET MAUI's WinUI implementation of BlazorWebView.

@Eilon Eilon requested review from PureWeen and javiercn June 4, 2021 18:05
Copy link
Member

@javiercn javiercn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@Redth Redth merged commit 8146fb7 into main Jun 7, 2021
@Redth Redth deleted the eilon/use-new-webview2-abstractions branch June 7, 2021 16:32
@Eilon Eilon added the area-blazor Blazor Hybrid / Desktop, BlazorWebView label Sep 30, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Dec 26, 2023
@samhouts samhouts added the fixed-in-6.0.100-preview.5 Look for this fix in 6.0.100-preview.5! label Aug 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-blazor Blazor Hybrid / Desktop, BlazorWebView fixed-in-6.0.100-preview.5 Look for this fix in 6.0.100-preview.5!

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants