Skip to content

Conversation

@jonathanpeppers
Copy link
Member

@jonathanpeppers jonathanpeppers commented Jun 2, 2020

Fixes: #16

$(TargetFramework) should be net5.0 now.

Android has the following fixes:

This enables several workarounds to be removed.

Also use the same .NET 5 build as xamarin-android:

https://github.com/xamarin/xamarin-android/blob/cde7b79dce48d9f3fdfc396641a01fb27d165042/build-tools/automation/azure-pipelines.yaml#L53

I updated the README.md and our Azure DevOps build pipeline.

@jonathanpeppers jonathanpeppers force-pushed the bump-everything branch 6 times, most recently from b167a92 to 81f0ea5 Compare June 3, 2020 15:38
Fixes: #16

`$(TargetFramework)` should be `net5.0` now.

Android has the following fixes:

* dotnet/android#4663
* dotnet/android#4692

This enables several workarounds to be removed.

Also use the same .NET 5 build as `xamarin-android`:

https://github.com/xamarin/xamarin-android/blob/cde7b79dce48d9f3fdfc396641a01fb27d165042/build-tools/automation/azure-pipelines.yaml#L53

I updated the `README.md` and our Azure DevOps build pipeline.
@dotnet dotnet deleted a comment from azure-pipelines bot Jun 3, 2020
@jonathanpeppers jonathanpeppers marked this pull request as ready for review June 3, 2020 16:24
@jonathanpeppers jonathanpeppers merged commit 27ac8fe into master Jun 4, 2020
@jonathanpeppers jonathanpeppers deleted the bump-everything branch June 4, 2020 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Target framework is netcoreapp5.0 not net5.0

4 participants