Skip to content

Conversation

@ericstj
Copy link
Member

@ericstj ericstj commented Oct 27, 2025

Building on MacOS was taking an additional 30+ minutes as it built dependencies like CMake, OpenSSL, etc from source.

Leverage the common script for installing dependencies used by runtime and other dotnet repos.

Copilot AI review requested due to automatic review settings October 27, 2025 16:56
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR optimizes macOS build times by replacing manual dependency installation with the arcade script used across dotnet repositories. The change eliminates a 30+ minute overhead caused by building dependencies like CMake and OpenSSL from source.

Key Changes:

  • Replaced brew update with arcade's install-dependencies.sh script for macOS builds
  • Applied change consistently across all macOS build configurations

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
build/vsts-ci.yml Updated two macOS build job configurations to use arcade script
build/ci/job-template.yml Updated macOS-specific dependency installation step to use arcade script

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codecov
Copy link

codecov bot commented Oct 27, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 69.02%. Comparing base (b28b6d4) to head (d15b132).
⚠️ Report is 9 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7533      +/-   ##
==========================================
- Coverage   69.02%   69.02%   -0.01%     
==========================================
  Files        1482     1482              
  Lines      274092   274093       +1     
  Branches    28266    28266              
==========================================
- Hits       189193   189191       -2     
- Misses      77511    77520       +9     
+ Partials     7388     7382       -6     
Flag Coverage Δ
Debug 69.02% <ø> (-0.01%) ⬇️
production 63.31% <ø> (-0.01%) ⬇️
test 89.47% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.
see 12 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ericstj
Copy link
Member Author

ericstj commented Oct 27, 2025

Windows ARM helix queues are busted. Bypassing.

@ericstj ericstj merged commit 8262217 into dotnet:main Oct 27, 2025
21 of 25 checks passed
@ericstj
Copy link
Member Author

ericstj commented Oct 27, 2025

/backport to release/4.0

@github-actions
Copy link
Contributor

Started backporting to release/4.0 (link to workflow run)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants