Skip to content

Support O3 OpenAI model mapping #7394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 21, 2025
Merged

Support O3 OpenAI model mapping #7394

merged 2 commits into from
Feb 21, 2025

Conversation

@tarekgh
Copy link
Member

@tarekgh tarekgh commented Feb 21, 2025

Fixes #7375

Copilot AI review requested due to automatic review settings February 21, 2025 01:12
Copilot AI reviewed Feb 21, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

@tarekgh
Copy link
Member Author

tarekgh commented Feb 21, 2025

CC @luisquintanilla @stephentoub @ericstj @michaelgsharp

stephentoub
stephentoub approved these changes Feb 21, 2025
View reviewed changes
Copy link
Member

@stephentoub stephentoub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@tarekgh
Copy link
Member Author

tarekgh commented Feb 21, 2025 •
edited
Loading

@ericstj I am planning to port this change to servicing too. It is a trivial change and not risky but will give value to the released version.

@tarekgh tarekgh merged commit 99723e7 into dotnet:main Feb 21, 2025
2 checks passed
@tarekgh tarekgh added this to the ML.NET Future milestone Feb 21, 2025
@tarekgh
Copy link
Member Author

tarekgh commented Feb 21, 2025

/backport to release/4.0

@github-actions
Copy link
Contributor

github-actions bot commented Feb 21, 2025

Started backporting to release/4.0: https://github.com/dotnet/machinelearning/actions/runs/13448034814

@github-actions github-actions bot mentioned this pull request Feb 21, 2025
Merged
@tarekgh
Copy link
Member Author

tarekgh commented Feb 21, 2025

Opened #7395 for porting

This was referenced Feb 21, 2025
Open
Open
Open
@github-actions github-actions bot locked and limited conversation to collaborators Mar 23, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@stephentoub stephentoub stephentoub approved these changes

Copilot code review Copilot Copilot left review comments

Assignees

@tarekgh tarekgh

Labels

Tokenizers

Projects

None yet

Milestone

ML.NET Future

Development

Successfully merging this pull request may close these issues.

o3 and o3-mini support for tokenizer

2 participants

@tarekgh @stephentoub