Skip to content

Update version for 5.0 #7311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 18, 2024
Merged

Update version for 5.0 #7311

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions eng/BranchInfo.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,15 +28,15 @@
<IsStableProject Condition="'$(StableProjects.IndexOf($(_NormalizedStableProjectName), StringComparison.OrdinalIgnoreCase))' != '-1'">true</IsStableProject>
</PropertyGroup>
<PropertyGroup Condition="'$(IsStableProject)' == 'true'">
<MajorVersion>4</MajorVersion>
<MajorVersion>5</MajorVersion>
<MinorVersion>0</MinorVersion>
<PatchVersion>0</PatchVersion>
<!-- Set baseline version for stable packages to check for API Compat -->
<PackageValidationBaselineVersion>3.0.0</PackageValidationBaselineVersion>
<PackageValidationBaselineVersion>$([MSBuild]::Subtract($(MajorVersion), 1)).0.0</PackageValidationBaselineVersion>
</PropertyGroup>
<PropertyGroup Condition="'$(IsStableProject)' != 'true'">
<MajorVersion>0</MajorVersion>
<MinorVersion>22</MinorVersion>
<MinorVersion>23</MinorVersion>
Copy link
Member

@tarekgh tarekgh Nov 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

23

can this get generated from year number? just thought :-)

Copy link
Member Author

@ericstj ericstj Nov 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, but I could calculate it from the stable product version. That would be more refactoring than I wanted to do.

<PatchVersion>0</PatchVersion>
</PropertyGroup>
</Project>
1 change: 0 additions & 1 deletion eng/Versions.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@
https://github.com/dotnet/arcade/blob/c788ffa83b088cafe9dbffc1cbc8155ba88b2553/Documentation/CorePackages/Versioning.md#output
-->
<DotNetUseShippingVersions>true</DotNetUseShippingVersions>
<VersionPrefix>4.0.0</VersionPrefix>
<PreReleaseVersionLabel>preview</PreReleaseVersionLabel>
<AssemblyVersion>1.0.0.0</AssemblyVersion>
<!-- .NET Runtime product dependencies -->
Expand Down
3 changes: 1 addition & 2 deletions src/Microsoft.ML.Tokenizers/Directory.Build.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,7 @@

<PropertyGroup>
<MajorVersion>$([MSBuild]::Subtract($(MajorVersion), 3))</MajorVersion>
<!-- Blank version for now for API compat -->
<PackageValidationBaselineVersion></PackageValidationBaselineVersion>
<PackageValidationBaselineVersion>$([MSBuild]::Subtract($(MajorVersion), 1)).0.0</PackageValidationBaselineVersion>
</PropertyGroup>

</Project>
12 changes: 0 additions & 12 deletions src/Microsoft.ML/CompatibilitySuppressions.xml
View file
Open in desktop

This file was deleted.

Loading