Skip to content

Conversation

@LittleLittleCloud
Copy link
Member

@LittleLittleCloud LittleLittleCloud commented Aug 29, 2024

We are excited to review your PR.

So we can do the best job, please check:

  • There's a descriptive title that will make sense to other developers some time from now.
  • There's associated issues. All PR's should have issue(s) associated - unless a trivial self-evident change such as fixing a typo. You can use the format Fixes #nnnn in your description to cause GitHub to automatically close the issue(s) when your PR is merged.
  • Your change description explains what the change does, why you chose your approach, and anything else that reviewers should know.
  • You have included any necessary tests in the same PR.

https://dnceng.visualstudio.com/internal/_componentGovernance/dotnet-machinelearning/alert/9167777?typeId=13269444

@codecov
Copy link

codecov bot commented Aug 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.83%. Comparing base (1612edc) to head (1747e3a).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7228   +/-   ##
=======================================
  Coverage   68.83%   68.83%           
=======================================
  Files        1453     1453           
  Lines      271482   271482           
  Branches    28090    28090           
=======================================
  Hits       186886   186886           
+ Misses      77376    77375    -1     
- Partials     7220     7221    +1     
Flag Coverage Δ
Debug 68.83% <ø> (ø)
production 63.35% <ø> (ø)
test 89.03% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 5 files with indirect coverage changes

@LittleLittleCloud LittleLittleCloud changed the title update approvaltest to 7.0.0 to fix security vulnerable package Directly refer sql data client 4.8.6 package in GenAI tests to fix security vulnerable package Aug 30, 2024
@LittleLittleCloud LittleLittleCloud merged commit 1d1cc99 into dotnet:main Aug 30, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Sep 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants