Skip to content

Conversation

@LittleLittleCloud
Copy link
Member

@LittleLittleCloud LittleLittleCloud commented Jun 18, 2024

We are excited to review your PR.

So we can do the best job, please check:

  • There's a descriptive title that will make sense to other developers some time from now.
  • There's associated issues. All PR's should have issue(s) associated - unless a trivial self-evident change such as fixing a typo. You can use the format Fixes #nnnn in your description to cause GitHub to automatically close the issue(s) when your PR is merged.
  • Your change description explains what the change does, why you chose your approach, and anything else that reviewers should know.
  • You have included any necessary tests in the same PR.

#7169 Task 2

@codecov
Copy link

codecov bot commented Jun 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.67%. Comparing base (8e3f72d) to head (e39c8fc).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7177      +/-   ##
==========================================
- Coverage   68.67%   68.67%   -0.01%     
==========================================
  Files        1263     1263              
  Lines      257955   257955              
  Branches    26698    26698              
==========================================
- Hits       177148   177140       -8     
- Misses      73994    74001       +7     
- Partials     6813     6814       +1     
Flag Coverage Δ
Debug 68.67% <ø> (-0.01%) ⬇️
production 62.93% <ø> (-0.01%) ⬇️
test 88.88% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 3 files with indirect coverage changes

string[]? stopSequences = null,
int eosId = 0,
string device = "cpu",
bool bos = true,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We prefer to have these things in a "default" class. If you look at the normal transformers you can see how we do it.
NOT a blocking issue though.

@LittleLittleCloud LittleLittleCloud merged commit 77e9024 into dotnet:main Jun 26, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Jul 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants