Skip to content

Conversation

@github-actions
Copy link
Contributor

@github-actions github-actions bot commented Jan 10, 2024

Backport of #6951 to release/3.0

/cc @michaelgsharp @LittleLittleCloud

Customer Impact

There is no workaround an end user could do to avoid this issue if they do hit it.

Testing

This exposed a testing hole that we have. We are going to add in "package testing" in order to catch situations like this before they are released.

Risk

Mid level risk. We are adding a new public type that could potentially have collisions with user.

@codecov
Copy link

codecov bot commented Jan 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (release/3.0@a5b5c7a). Click here to learn what that means.

Additional details and impacted files
@@              Coverage Diff               @@
##             release/3.0    #6953   +/-   ##
==============================================
  Coverage               ?   68.80%           
==============================================
  Files                  ?     1240           
  Lines                  ?   249652           
  Branches               ?    25511           
==============================================
  Hits                   ?   171774           
  Misses                 ?    71277           
  Partials               ?     6601           
Flag Coverage Δ
Debug 68.80% <0.00%> (?)
production 63.27% <0.00%> (?)
test 88.41% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

@michaelgsharp michaelgsharp requested a review from ericstj January 11, 2024 19:10
Copy link
Member

@ericstj ericstj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, let's update template as we discussed.

@michaelgsharp michaelgsharp merged commit ec498d8 into release/3.0 Jan 13, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Feb 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants