Skip to content

Conversation

@github-actions
Copy link
Contributor

@github-actions github-actions bot commented Jan 8, 2024

Backport of #6928 to release/3.0

/cc @michaelgsharp

Customer Impact

Initially, when a work was split into multiple tokens, the user had to figure that out and expand the labels as well. This PR fixes that by auto expanding/contracting the labels as needed.

Testing

There are automated tests that have examples that were problematic during testing, as well as a complete run was done on a GPU machine (75k lines in the test file).

Risk

With the automated tests and full GPU machine test run, minimal to no risk.

Copy link
Member

@ericstj ericstj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For anyone that worked around the original problem, will they need any advice to remove the workaround, or can they just delete it when taking this update?

@michaelgsharp
Copy link
Contributor

They can just delete it.

@codecov
Copy link

codecov bot commented Jan 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (release/3.0@66c06e6). Click here to learn what that means.

Additional details and impacted files
@@              Coverage Diff               @@
##             release/3.0    #6946   +/-   ##
==============================================
  Coverage               ?   68.80%           
==============================================
  Files                  ?     1240           
  Lines                  ?   249601           
  Branches               ?    25509           
==============================================
  Hits                   ?   171745           
  Misses                 ?    71256           
  Partials               ?     6600           
Flag Coverage Δ
Debug 68.80% <0.00%> (?)
production 63.27% <0.00%> (?)
test 88.41% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

@michaelgsharp michaelgsharp merged commit 4f268c7 into release/3.0 Jan 9, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Feb 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants