Skip to content

Fix assert by only accessing idx #6924

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 22, 2023
Merged

Fix assert by only accessing idx #6924

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions src/Microsoft.ML.Data/DataView/CacheDataView.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1320,7 +1320,7 @@ public virtual void Freeze()

private sealed class ImplVec<T> : ColumnCache<VBuffer<T>>
{
// The number of rows cached.
// The number of rows cached. Only to be accesssed by the Caching thread.
private int _rowCount;
// For a given row [r], elements at [r] and [r+1] specify the inclusive
// and exclusive range of values for the two big arrays. In the case
Expand Down Expand Up @@ -1384,10 +1384,10 @@ public override void CacheCurrent()

public override void Fetch(int idx, ref VBuffer<T> value)
{
Ctx.Assert(0 <= idx && idx < _rowCount);
Ctx.Assert(_rowCount < Utils.Size(_indexBoundaries));
Ctx.Assert(_rowCount < Utils.Size(_valueBoundaries));
Ctx.Assert(_uniformLength > 0 || _rowCount <= Utils.Size(_lengths));
Ctx.Assert(0 <= idx);
Ctx.Assert((idx + 1) < Utils.Size(_indexBoundaries));
Ctx.Assert((idx + 1) < Utils.Size(_valueBoundaries));
Ctx.Assert(_uniformLength > 0 || idx < Utils.Size(_lengths));

Ctx.Assert(_indexBoundaries[idx + 1] - _indexBoundaries[idx] <= int.MaxValue);
int indexCount = (int)(_indexBoundaries[idx + 1] - _indexBoundaries[idx]);
Expand Down