Skip to content

Conversation

@taeerhebend
Copy link
Contributor

We are excited to review your PR.

So we can do the best job, please check:

  • There's a descriptive title that will make sense to other developers some time from now.
  • There's associated issues. All PR's should have issue(s) associated - unless a trivial self-evident change such as fixing a typo. You can use the format Fixes #nnnn in your description to cause GitHub to automatically close the issue(s) when your PR is merged.
  • Your change description explains what the change does, why you chose your approach, and anything else that reviewers should know.
  • You have included any necessary tests in the same PR.

@codecov
Copy link

codecov bot commented Nov 29, 2023

Codecov Report

Merging #6895 (7fce0fe) into main (d96d7b7) will decrease coverage by 0.01%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6895      +/-   ##
==========================================
- Coverage   68.81%   68.81%   -0.01%     
==========================================
  Files        1240     1240              
  Lines      249397   249397              
  Branches    25496    25496              
==========================================
- Hits       171614   171611       -3     
- Misses      71189    71191       +2     
- Partials     6594     6595       +1     
Flag Coverage Δ
Debug 68.81% <ø> (-0.01%) ⬇️
production 63.27% <ø> (-0.01%) ⬇️
test 88.49% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

@michaelgsharp
Copy link
Contributor

Merging on red due to flaky test.

@michaelgsharp michaelgsharp merged commit 7366b99 into dotnet:main Dec 7, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jan 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants