Skip to content

Fix inconsistent null handling in DataFrame Arithmetics #6770

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 31, 2023
Merged

Fix inconsistent null handling in DataFrame Arithmetics #6770

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
a71e510
Fix inconsistent null handling in DataFrame Arithmetics
asmirnov82 Jul 20, 2023
0d09a5c
Fix Null Count and division by zero issues
asmirnov82 Jul 20, 2023
8f30c7a
Merge branch 'main' into 5650_inconsistent_null_handling_dataframe_ar…
asmirnov82 Aug 15, 2023
d1e974e
Merge remote-tracking branch 'origin/main' into 5650_inconsistent_nul…
asmirnov82 Aug 26, 2023
99bbe5d
Minor changes to restart build and rerun flaky tests
asmirnov82 Aug 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions src/Microsoft.Data.Analysis/PrimitiveColumnContainerHelpers.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,16 +11,14 @@ internal static class PrimitiveColumnContainerHelpers
internal static DataFrameBuffer<T> GetOrCreateMutable<T>(this IList<ReadOnlyDataFrameBuffer<T>> bufferList, int index)
where T : unmanaged
{
ReadOnlyDataFrameBuffer<T> sourceBuffer = bufferList[index];
DataFrameBuffer<T> mutableBuffer = sourceBuffer as DataFrameBuffer<T>;
var sourceBuffer = bufferList[index];

if (mutableBuffer == null)
if (sourceBuffer is not DataFrameBuffer<T> mutableBuffer)
{
mutableBuffer = DataFrameBuffer<T>.GetMutableBuffer(sourceBuffer);
bufferList[index] = mutableBuffer;
}


return mutableBuffer;
}
}
Expand Down
Loading