Skip to content

Run tests that requires more than 2 Gb of memory only on 64-bit env #6758

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 7, 2023
Merged

Run tests that requires more than 2 Gb of memory only on 64-bit env #6758

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions test/Microsoft.Data.Analysis.Tests/BufferTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
using System.Linq;
using System.Text;
using Apache.Arrow;
using Microsoft.ML.TestFramework.Attributes;
using Xunit;

namespace Microsoft.Data.Analysis.Tests
Expand Down Expand Up @@ -188,16 +189,15 @@ public void TestArrowStringColumnClone()
Assert.Null(clone[i]);
}

/* Don't run tests during build as they fail, because build if build machine doesn't have enought memory
[Fact]
[X64Fact("32-bit dosn't allow to allocate more than 2 Gb")]
public void TestAppend_SizeMoreThanMaxBufferCapacity()
{
//Check appending value, than can increase buffer size over MaxCapacity (default strategy is to double buffer capacity)
PrimitiveDataFrameColumn<byte> intColumn = new PrimitiveDataFrameColumn<byte>("Byte1", int.MaxValue / 2 - 1);
intColumn.Append(10);
}

[Fact]
[X64Fact("32-bit dosn't allow to allocate more than 2 Gb")]
public void TestAppendMany_SizeMoreThanMaxBufferCapacity()
{
const int MaxCapacityInBytes = 2147483591;
Expand All @@ -208,7 +208,6 @@ public void TestAppendMany_SizeMoreThanMaxBufferCapacity()

Assert.Equal(MaxCapacityInBytes + 5, intColumn.Length);
}
*/

//#if !NETFRAMEWORK // https://github.com/dotnet/corefxlab/issues/2796
// [Fact]
Expand Down