Skip to content

Update build templates to handle feature branches #6744

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 28, 2023
Merged

Update build templates to handle feature branches #6744

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
715b0ca
Update build templates
JakeRadMSFT Jun 23, 2023
dd62d02
JakeRadMSFT Jun 24, 2023
3e9d2dc
JakeRadMSFT Jun 26, 2023
0b6fae3
JakeRadMSFT Jun 26, 2023
d24e8a8
JakeRadMSFT Jun 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions .vsts-dotnet-ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,20 @@
# ML.NET's PR validation build
################################################################################

pr:
branches:
include:
- main
- feature/*
- release/*

trigger:
branches:
include:
- main
- feature/*
- release/*

resources:
containers:
- container: CentosContainer
Expand Down
5 changes: 2 additions & 3 deletions build/.night-build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,8 @@ schedules:
branches:
include:
- main
- releases/1.6.0
- features/automl
- features/integrationPackage
- feature/*
Copy link
Member

@ericstj ericstj Jun 23, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should remove those other explicit features, and maybe we should add a release wildcard as well. What do you think @michaelgsharp?

Copy link
Member Author

@JakeRadMSFT JakeRadMSFT Jun 23, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought about it and figured it would come up in the PR :).

The other ones are "features" but I'm not sure if we still need them?

+1 on releases!

Copy link
Member

@ericstj ericstj Jun 26, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it should be release/*. Probably this is somewhat stale.

Copy link
Member Author

@JakeRadMSFT JakeRadMSFT Jun 26, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree - happy to change it but all the old branches are - releases/* . Should I update the template to be release/* but leave the old branches named the same?

Copy link
Member

@ericstj ericstj Jun 26, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Old branches are effectively dead now and won’t be building any more. Our servicing policy is roll forward to latest

- release/*
always: true

resources:
Expand Down
5 changes: 2 additions & 3 deletions build/.outer-loop-build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,8 @@ schedules:
branches:
include:
- main
- releases/1.6.0
- features/automl
- features/integrationPackage
- feature/*
- release/*
always: true


Expand Down
14 changes: 14 additions & 0 deletions build/codecoverage-ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,20 @@
# ML.NET's Code Coverage validation build
################################################################################

pr:
branches:
include:
- main
- feature/*
- release/*

trigger:
branches:
include:
- main
- feature/*
- release/*

jobs:
- template: /build/ci/job-template.yml
parameters:
Expand Down