-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Fix DataFrame Merge issue #6677
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix DataFrame Merge issue #6677
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #6677 +/- ##
=======================================
Coverage ? 68.80%
=======================================
Files ? 1215
Lines ? 251857
Branches ? 26257
=======================================
Hits ? 173280
Misses ? 71765
Partials ? 6812
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
michaelgsharp
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for submitting this!
|
Merged into Generic Math branch. (This is just a note for myself) |
Change Clone method to return correct ColumnType for all inheritors of PrimitiveDataFrameColumn class. Before the fix column of parent PrimitiveDataFrameColumn was returned instead
Fixes #6127