Skip to content

Conversation

@JakeRadMSFT
Copy link
Member

@JakeRadMSFT JakeRadMSFT commented Nov 4, 2022

We are excited to review your PR.

So we can do the best job, please check:

  • There's a descriptive title that will make sense to other developers some time from now.
  • There's associated issues. All PR's should have issue(s) associated - unless a trivial self-evident change such as fixing a typo. You can use the format Fixes #nnnn in your description to cause GitHub to automatically close the issue(s) when your PR is merged.
  • Your change description explains what the change does, why you chose your approach, and anything else that reviewers should know.
  • You have included any necessary tests in the same PR.

Fixes: #6428

@JakeRadMSFT
Copy link
Member Author

@ericstj @michaelgsharp - could you help add 0.98.3 to our proxy feed?

@JakeRadMSFT JakeRadMSFT requested a review from ericstj November 4, 2022 23:31
@ericstj
Copy link
Member

ericstj commented Nov 7, 2022

@JakeRadMSFT we requested this from the core-eng team and they have pushed the package(s).

@codecov
Copy link

codecov bot commented Nov 7, 2022

Codecov Report

Merging #6436 (4a78339) into main (025e373) will decrease coverage by 0.00%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6436      +/-   ##
==========================================
- Coverage   68.50%   68.49%   -0.01%     
==========================================
  Files        1170     1170              
  Lines      246977   246977              
  Branches    25792    25792              
==========================================
- Hits       169187   169165      -22     
- Misses      71045    71072      +27     
+ Partials     6745     6740       -5     
Flag Coverage Δ
Debug 68.49% <ø> (-0.01%) ⬇️
production 62.88% <ø> (-0.02%) ⬇️
test 88.96% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...c/Microsoft.ML.FastTree/Utils/ThreadTaskManager.cs 79.48% <0.00%> (-20.52%) ⬇️
src/Microsoft.ML.Core/Data/ProgressReporter.cs 70.95% <0.00%> (-6.99%) ⬇️
...soft.ML.Data/DataLoadSave/Text/TextLoaderCursor.cs 89.61% <0.00%> (-0.16%) ⬇️
...ML.Transforms/Text/StopWordsRemovingTransformer.cs 86.53% <0.00%> (+0.14%) ⬆️
...soft.ML.Transforms/Text/WordEmbeddingsExtractor.cs 86.87% <0.00%> (+1.13%) ⬆️

@ericstj ericstj merged commit 17c061a into main Nov 7, 2022
Copy link
Member

@ericstj ericstj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ghost ghost locked as resolved and limited conversation to collaborators Dec 8, 2022
@michaelgsharp michaelgsharp deleted the u/jakerad/bump-torch branch May 10, 2023 20:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Upgrade to TorchSharp 0.98.3

3 participants