Skip to content

Conversation

@LittleLittleCloud
Copy link
Member

@LittleLittleCloud LittleLittleCloud commented Oct 24, 2022

We are excited to review your PR.

So we can do the best job, please check:

  • There's a descriptive title that will make sense to other developers some time from now.
  • There's associated issues. All PR's should have issue(s) associated - unless a trivial self-evident change such as fixing a typo. You can use the format Fixes #nnnn in your description to cause GitHub to automatically close the issue(s) when your PR is merged.
  • Your change description explains what the change does, why you chose your approach, and anything else that reviewers should know.
  • You have included any necessary tests in the same PR.

fix #6407

@codecov
Copy link

codecov bot commented Oct 24, 2022

Codecov Report

Merging #6406 (e0de33b) into main (1903fa5) will decrease coverage by 0.00%.
The diff coverage is 72.72%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6406      +/-   ##
==========================================
- Coverage   68.53%   68.53%   -0.01%     
==========================================
  Files        1169     1169              
  Lines      246863   246877      +14     
  Branches    25782    25788       +6     
==========================================
+ Hits       169198   169202       +4     
- Misses      70948    70949       +1     
- Partials     6717     6726       +9     
Flag Coverage Δ
Debug 68.53% <72.72%> (-0.01%) ⬇️
production 62.94% <65.57%> (-0.01%) ⬇️
test 88.94% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/Microsoft.ML.TorchSharp/Utils/FileUtils.cs 0.00% <ø> (-24.62%) ⬇️
test/Microsoft.ML.Tests/TextClassificationTests.cs 94.83% <ø> (ø)
...rc/Microsoft.ML.Tokenizers/Model/EnglishRoberta.cs 78.53% <62.50%> (-2.51%) ⬇️
...ft.ML.TorchSharp/Extensions/TokenizerExtensions.cs 87.50% <100.00%> (-0.97%) ⬇️
...Microsoft.ML.AutoML.Tests/AutoMLExperimentTests.cs 96.35% <100.00%> (+0.12%) ⬆️
...crosoft.ML.Tokenizers.Tests/EnglishRobertaTests.cs 100.00% <100.00%> (ø)
...soft.ML.Transforms/Text/WordEmbeddingsExtractor.cs 85.74% <0.00%> (-1.14%) ⬇️
...soft.ML.Data/DataLoadSave/Text/TextLoaderCursor.cs 89.77% <0.00%> (-0.64%) ⬇️
src/Microsoft.ML.Core/Utilities/Contracts.cs 45.87% <0.00%> (-0.41%) ⬇️
...ML.Transforms/Text/StopWordsRemovingTransformer.cs 86.38% <0.00%> (-0.15%) ⬇️

@michaelgsharp michaelgsharp merged commit 73beb28 into dotnet:main Oct 25, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Nov 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

EciCfoTuner doesn't respect seed value from AutoMLExperiment.Settings.Seed

2 participants