-
Notifications
You must be signed in to change notification settings - Fork 1.9k
XGBoost integration infrastructure (still temporarily using Estimator rather than Trainer) #6345
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t an approximate result
* Add DataFrame.IO tests with separators in data * Add test where comma is in header * Add two versions of test cases, likely going to use the helper version * Fix separators in data * Fix separators in header * Clean up tests * Fix issue with not wrapping output with newlines in quotations * Accidental commit * Clean up * Clean up mini test framework a bit * Apply suggestions from code review Co-authored-by: Eric Erhardt <[email protected]> * Apply suggestions from code review * Apply suggestions from code review * Write to StreamWriter directly Co-authored-by: Eric Erhardt <[email protected]>
Member
|
Do you want to merge it to onedal-integration or main branch? |
Contributor
Author
|
To onedal-integration, please... |
4 tasks
Contributor
Author
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are excited to review your PR.
So we can do the best job, please check:
Fixes #nnnnin your description to cause GitHub to automatically close the issue(s) when your PR is merged.Strictly this is independent of OneDAL (XGBoost and OneDAL are separate libraries), but adding to this feature branch for convenience. This payload includes the PInvoke infrastructure to call XGBoost (version 1.5 and above... current version is 1.7). It mimics the design of the LightGBM integration as much as possible. Most notable difference is that it does not serialize to
InternalEnsembleTree, but uses its own model (also it uses the JSON dump to build such a model, but that's an implementation detail). The actual Estimator/Transformer pair is preliminary, as it looks more like a standard transformation than a learner (in that the Model is not an independent entity). This most likely will need to change.