Skip to content

LightGBM parameter changes to match Python implementation results #6064

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 10 commits into from
Closed

LightGBM parameter changes to match Python implementation results #6064

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
0ee875b
Update LightGbmTrainerBase.cs
torronen Jan 30, 2022
e2c2f45
Update LightGbmTrainerBase.cs
torronen Jan 30, 2022
d9ad922
Update LightGbmBinaryTrainer.cs
torronen Jan 30, 2022
dfd8cd1
syntax fix
torronen Jan 30, 2022
1a69660
num_iterations instead of alias
torronen Jan 31, 2022
eea96ac
style fix
torronen Jan 31, 2022
a91d9d4
NumberOfIterations to LightGBM param array
torronen Feb 1, 2022
badc83a
LightGBM default metric EvaluateMetricType.None
torronen Feb 1, 2022
c392524
MinimumExampleCountPerLeaf & LearningRate to array
torronen Feb 1, 2022
59c614c
Update LightGbmTrainerBase.cs
torronen Feb 1, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/Microsoft.ML.LightGbm/LightGbmBinaryTrainer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,15 +155,15 @@ public enum EvaluateMetricType
/// </summary>
[Argument(ArgumentType.AtMostOnce, HelpText = "Parameter for the sigmoid function.", ShortName = "sigmoid")]
[TGUI(Label = "Sigmoid", SuggestedSweeps = "0.5,1")]
public double Sigmoid = 0.5;
public double Sigmoid = 1;

/// <summary>
/// Determines what evaluation metric to use.
/// </summary>
[Argument(ArgumentType.AtMostOnce,
HelpText = "Evaluation metrics.",
ShortName = "em")]
public EvaluateMetricType EvaluationMetric = EvaluateMetricType.Logloss;
public EvaluateMetricType EvaluationMetric = EvaluateMetricType.None;

static Options()
{
Expand Down
8 changes: 6 additions & 2 deletions src/Microsoft.ML.LightGbm/LightGbmTrainerBase.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,8 @@ public class OptionsBase : TrainerInputBaseWithGroupId
{nameof(CategoricalSmoothing), "cat_smooth" },
{nameof(L2CategoricalRegularization), "cat_l2" },
{nameof(HandleMissingValue), "use_missing" },
{nameof(UseZeroAsMissingValue), "zero_as_missing" }
{nameof(UseZeroAsMissingValue), "zero_as_missing" },
{nameof(NumberOfIterations), "num_iterations" }
};

private protected string GetOptionName(string name)
Expand Down Expand Up @@ -264,7 +265,9 @@ internal virtual Dictionary<string, object> ToDictionary(IHost host)
if (NumberOfThreads.HasValue)
res["nthread"] = NumberOfThreads.Value;

res["seed"] = (Seed.HasValue) ? Seed : host.Rand.Next();
// keep lightgbm default seed if it has not been specified in Seed property
if (Seed.HasValue)
res["seed"] = Seed;

res[GetOptionName(nameof(MaximumBinCountPerFeature))] = MaximumBinCountPerFeature;
res[GetOptionName(nameof(HandleMissingValue))] = HandleMissingValue;
Expand All @@ -273,6 +276,7 @@ internal virtual Dictionary<string, object> ToDictionary(IHost host)
res[GetOptionName(nameof(MaximumCategoricalSplitPointCount))] = MaximumCategoricalSplitPointCount;
res[GetOptionName(nameof(CategoricalSmoothing))] = CategoricalSmoothing;
res[GetOptionName(nameof(L2CategoricalRegularization))] = L2CategoricalRegularization;
res[GetOptionName(nameof(NumberOfIterations))] = NumberOfIterations;

return res;
}
Expand Down