-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New build pools #6041
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New build pools #6041
Conversation
| DOTNET_CLI_TELEMETRY_OPTOUT: 1 | ||
| DOTNET_SKIP_FIRST_TIME_EXPERIENCE: 1 | ||
| DOTNET_MULTILEVEL_LOOKUP: 0 | ||
| NUGET_PACKAGES: $(Build.SourcesDirectory)/.packages |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this only necessary here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This gets set automatically by arcade during the build phase, so usually nothing is needed. In the final step of our official build though we build/pack, sign, and upload symbols in different steps. Because they happen in different steps the value is incorrect during all steps except our build/pack.
tarekgh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Modulo @eerhardt question, LGTM
Codecov Report
@@ Coverage Diff @@
## main #6041 +/- ##
==========================================
- Coverage 68.54% 68.53% -0.01%
==========================================
Files 1146 1146
Lines 245450 245450
Branches 25637 25637
==========================================
- Hits 168244 168228 -16
- Misses 70498 70509 +11
- Partials 6708 6713 +5
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Update the official build to the new pools.