Skip to content

Conversation

@michaelgsharp
Copy link
Contributor

Update the official build to the new pools.

@michaelgsharp michaelgsharp requested review from a team, eerhardt, ericstj and safern January 11, 2022 17:19
DOTNET_CLI_TELEMETRY_OPTOUT: 1
DOTNET_SKIP_FIRST_TIME_EXPERIENCE: 1
DOTNET_MULTILEVEL_LOOKUP: 0
NUGET_PACKAGES: $(Build.SourcesDirectory)/.packages
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this only necessary here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This gets set automatically by arcade during the build phase, so usually nothing is needed. In the final step of our official build though we build/pack, sign, and upload symbols in different steps. Because they happen in different steps the value is incorrect during all steps except our build/pack.

Copy link
Member

@tarekgh tarekgh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Modulo @eerhardt question, LGTM

@codecov
Copy link

codecov bot commented Jan 12, 2022

Codecov Report

Merging #6041 (bfc0a44) into main (0b2bd3a) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #6041      +/-   ##
==========================================
- Coverage   68.54%   68.53%   -0.01%     
==========================================
  Files        1146     1146              
  Lines      245450   245450              
  Branches    25637    25637              
==========================================
- Hits       168244   168228      -16     
- Misses      70498    70509      +11     
- Partials     6708     6713       +5     
Flag Coverage Δ
Debug 68.53% <ø> (-0.01%) ⬇️
production 63.32% <ø> (-0.01%) ⬇️
test 88.67% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...c/Microsoft.ML.FastTree/Utils/ThreadTaskManager.cs 79.48% <0.00%> (-20.52%) ⬇️
...est/Microsoft.ML.Core.Tests/UnitTests/TestHosts.cs 96.55% <0.00%> (-3.45%) ⬇️
src/Microsoft.ML.Maml/MAML.cs 25.38% <0.00%> (-1.53%) ⬇️
src/Microsoft.ML.Sweeper/AsyncSweeper.cs 71.42% <0.00%> (-1.37%) ⬇️
...ML.Transforms/Text/StopWordsRemovingTransformer.cs 86.23% <0.00%> (-0.15%) ⬇️
src/Microsoft.ML.Transforms/Text/LdaTransform.cs 88.44% <0.00%> (+0.14%) ⬆️

@michaelgsharp michaelgsharp merged commit ae97ece into dotnet:main Jan 12, 2022
@michaelgsharp michaelgsharp deleted the pool-testing branch January 12, 2022 17:29
@ghost ghost locked as resolved and limited conversation to collaborators Mar 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants