Skip to content

[Src] Fixed typo: files in Microsoft.ML namespace #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 7, 2018
Merged

[Src] Fixed typo: files in Microsoft.ML namespace #59

merged 3 commits into from
May 7, 2018

Conversation

@yamachu
Copy link
Contributor

@yamachu yamachu commented May 7, 2018 •
edited by TomFinley
Loading

  • There's a descriptive title that will make sense to other developers some time from now.
  • There's associated issues. All PR's should have issue(s) associated - unless a trivial self-evident change such as fixing a typo. You can use the format Fixes #nnnn in your description to cause GitHub to automatically close the issue(s) when your PR is merged.
  • Your change description explains what the change does, why you chose your approach, and anything else that reviewers should know.
  • You have included any necessary tests in the same PR.

@shauheen
Copy link
Contributor

shauheen commented May 7, 2018

Thanks @yamachu for your PR :)

eerhardt
eerhardt approved these changes May 7, 2018
View reviewed changes
Copy link
Member

@eerhardt eerhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @yamachu !

TomFinley
TomFinley approved these changes May 7, 2018
View reviewed changes
Copy link
Contributor

@TomFinley TomFinley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@shauheen shauheen merged commit af95f66 into dotnet:master May 7, 2018
eerhardt pushed a commit to eerhardt/machinelearning that referenced this pull request Jul 27, 2018
@yamachu @eerhardt
[Src] Fixed typo: files in Microsoft.ML namespace (dotnet#59)
f39f777 
* Fix typo evaulate -> evaluate

* Fix typo validataion -> validation

* Refine private method name
@ghost ghost locked as resolved and limited conversation to collaborators Mar 31, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@eerhardt eerhardt eerhardt approved these changes

+1 more reviewer

@TomFinley TomFinley TomFinley approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@yamachu @shauheen @eerhardt @TomFinley