Skip to content

Conversation

@LittleLittleCloud
Copy link
Member

@LittleLittleCloud LittleLittleCloud commented May 27, 2021

We are excited to review your PR.

So we can do the best job, please check:

  • There's a descriptive title that will make sense to other developers some time from now.
  • There's associated issues. All PR's should have issue(s) associated - unless a trivial self-evident change such as fixing a typo. You can use the format Fixes #nnnn in your description to cause GitHub to automatically close the issue(s) when your PR is merged.
  • Your change description explains what the change does, why you chose your approach, and anything else that reviewers should know.
  • You have included any necessary tests in the same PR.

Portable pdbs will always fail symbol archive check in VS, because they cannot be archived on the legacy symbols system. Therefore upload classic pdb in publish.proj as well
#5817

@LittleLittleCloud LittleLittleCloud marked this pull request as draft May 27, 2021 19:44
@codecov
Copy link

codecov bot commented May 27, 2021

Codecov Report

Merging #5816 (d2cf215) into main (7fafbf3) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #5816   +/-   ##
=======================================
  Coverage   68.32%   68.32%           
=======================================
  Files        1131     1131           
  Lines      241291   241291           
  Branches    25053    25053           
=======================================
+ Hits       164863   164867    +4     
+ Misses      69923    69922    -1     
+ Partials     6505     6502    -3     
Flag Coverage Δ
Debug 68.32% <ø> (+<0.01%) ⬆️
production 62.93% <ø> (+<0.01%) ⬆️
test 89.24% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
....ML.AutoML/PipelineSuggesters/PipelineSuggester.cs 78.74% <0.00%> (-3.15%) ⬇️
...ML.Transforms/Text/StopWordsRemovingTransformer.cs 86.67% <0.00%> (+0.14%) ⬆️
...StandardTrainers/Standard/LinearModelParameters.cs 66.32% <0.00%> (+0.25%) ⬆️
src/Microsoft.ML.Sweeper/AsyncSweeper.cs 72.78% <0.00%> (+1.36%) ⬆️
...rosoft.ML.AutoML/ColumnInference/TextFileSample.cs 62.25% <0.00%> (+2.64%) ⬆️

@LittleLittleCloud LittleLittleCloud marked this pull request as ready for review May 27, 2021 22:13
@LittleLittleCloud LittleLittleCloud changed the title use cibuild to upload symbols convert portable pdb to classic pdb May 28, 2021
@LittleLittleCloud LittleLittleCloud force-pushed the u/xiaoyun/fixUploadSymbol branch from 535cf47 to d2cf215 Compare May 28, 2021 18:01
@LittleLittleCloud LittleLittleCloud changed the title convert portable pdb to classic pdb upload classic pdb to symweb Jun 1, 2021
Copy link
Contributor

@michaelgsharp michaelgsharp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit: LGTM

@michaelgsharp michaelgsharp merged commit d266c86 into dotnet:main Jun 1, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Mar 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants