Skip to content

Conversation

@harishsk
Copy link
Contributor

No description provided.

@harishsk harishsk requested a review from a team as a code owner May 21, 2020 23:15
- Add escapeChar support to TextLoader ([#5147](https://github.com/dotnet/machinelearning/pull/5147))
- Add public generic methods to TextLoader catalog that accept Options objects ([#5134](https://github.com/dotnet/machinelearning/pull/5134))
- Added decimal marker option in TextLoader ([#5145](https://github.com/dotnet/machinelearning/pull/5145))
- Onnxruntime updated to v1.3
Copy link
Contributor

@antoniovs1029 antoniovs1029 May 21, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps add this PR as reference of updating Onnxruntime?
#5104 #Resolved

@mstfbl
Copy link
Contributor

mstfbl commented May 26, 2020

These PR's have been merged and are not present in the 1.5.0 Release features. Should they be added?

@codecov
Copy link

codecov bot commented May 26, 2020

Codecov Report

Merging #5151 into master will decrease coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #5151      +/-   ##
==========================================
- Coverage   75.79%   75.75%   -0.04%     
==========================================
  Files         993      993              
  Lines      180955   180715     -240     
  Branches    19486    19463      -23     
==========================================
- Hits       137151   136903     -248     
- Misses      38514    38517       +3     
- Partials     5290     5295       +5     
Flag Coverage Δ
#Debug 75.75% <ø> (-0.04%) ⬇️
#production 71.70% <ø> (-0.02%) ⬇️
#test 88.84% <ø> (-0.06%) ⬇️
Impacted Files Coverage Δ
....ML.AutoML/PipelineSuggesters/PipelineSuggester.cs 79.83% <0.00%> (-6.73%) ⬇️
...soft.ML.AutoML/ColumnInference/TextFileContents.cs 89.55% <0.00%> (-4.90%) ⬇️
src/Microsoft.ML.AutoML/Sweepers/Parameters.cs 83.47% <0.00%> (-1.70%) ⬇️
...soft.ML.Data/DataLoadSave/Text/TextLoaderParser.cs 86.12% <0.00%> (-0.90%) ⬇️
test/Microsoft.ML.Tests/TextLoaderTests.cs 95.75% <0.00%> (-0.83%) ⬇️
...ft.ML.AutoML/ColumnInference/ColumnInferenceApi.cs 83.00% <0.00%> (-0.50%) ⬇️
.../Microsoft.ML.AutoML.Tests/ColumnInferenceTests.cs 99.20% <0.00%> (-0.12%) ⬇️
src/Microsoft.ML.Data/Data/Conversion.cs 77.20% <0.00%> (-0.09%) ⬇️
...t.ML.AutoML/ColumnInference/ColumnTypeInference.cs 85.46% <0.00%> (-0.07%) ⬇️
.../Microsoft.ML.Data/DataLoadSave/Text/TextLoader.cs 82.34% <0.00%> (+0.15%) ⬆️
... and 3 more

@codecov
Copy link

codecov bot commented May 26, 2020

Codecov Report

Merging #5151 into master will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #5151      +/-   ##
==========================================
- Coverage   75.79%   75.78%   -0.01%     
==========================================
  Files         993      993              
  Lines      180969   180969              
  Branches    19489    19489              
==========================================
- Hits       137159   137151       -8     
- Misses      38516    38521       +5     
- Partials     5294     5297       +3     
Flag Coverage Δ
#Debug 75.78% <ø> (-0.01%) ⬇️
#production 71.70% <ø> (-0.01%) ⬇️
#test 88.89% <ø> (ø)
Impacted Files Coverage Δ
...c/Microsoft.ML.FastTree/Utils/ThreadTaskManager.cs 79.48% <0.00%> (-20.52%) ⬇️
....ML.AutoML/PipelineSuggesters/PipelineSuggester.cs 79.83% <0.00%> (-6.73%) ⬇️
src/Microsoft.ML.AutoML/Sweepers/Parameters.cs 84.32% <0.00%> (-0.85%) ⬇️
...ML.Transforms/Text/StopWordsRemovingTransformer.cs 86.10% <0.00%> (-0.16%) ⬇️
...soft.ML.Data/DataLoadSave/Text/TextLoaderCursor.cs 89.58% <0.00%> (+0.32%) ⬆️
...soft.ML.Transforms/Text/WordEmbeddingsExtractor.cs 87.52% <0.00%> (+1.13%) ⬆️
...rosoft.ML.AutoML/ColumnInference/TextFileSample.cs 62.25% <0.00%> (+2.64%) ⬆️

Copy link
Contributor

@mstfbl mstfbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@harishsk harishsk merged commit 121a999 into dotnet:master May 26, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Mar 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants