Skip to content

Conversation

@frank-dong-ms-zz
Copy link
Contributor

@frank-dong-ms-zz frank-dong-ms-zz commented Mar 12, 2020

several issue here:

  1. delete useless folder to avoid no disk space
  2. add missing dependency for nightly build
  3. fix LD_LIBRARY_PATH for CentOS to set proper native reference path
  4. increase build time, seems it takes more time now for net core 3.0 to build

- script: $(dotnetPath) run --project $(packageUpdaterProjPath)
displayName: Update package versions for nightly build
- ${{ if eq(parameters.buildScript, 'build.cmd') }}:
- powershell: |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please explain why this is useless? If this useless, why do we have it in our tree and have it build?
If the reason is different, can you please add the actual reason? (Also, small typo: useless)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, for NightlyBuild pipeline only NightlyBuild test project is necessary, other test projects are built from previous "Build" step. This "Build" are doing multiple things thatNightlyBuild pipeline also requires, like initialize tools, build native components. We are reusing the "Build" step from CI build pipeline but with side effect that we are also building too much test projects. We can separate the build step into smaller steps and only include necessary steps in nightly build pipeline but that can be quite large effort and I'm not seeing much value of this.

And thanks for pointing out the typo, I will fix the typo


In reply to: 391391849 [](ancestors = 391391849)

@frank-dong-ms-zz frank-dong-ms-zz merged commit 0f6036c into dotnet:master Mar 12, 2020
@frank-dong-ms-zz frank-dong-ms-zz deleted the nightlybuild-fix branch April 7, 2020 04:29
@ghost ghost locked as resolved and limited conversation to collaborators Mar 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants