Skip to content

fix netfx test not running issue #4862

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 20, 2020
Merged

fix netfx test not running issue #4862

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion test/Directory.Build.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
<VSTestLogger>trx</VSTestLogger>
<VSTestResultsDirectory>$(OutputPath)</VSTestResultsDirectory>
<AssemblyOriginatorKeyFile>$(ToolsDir)Test.snk</AssemblyOriginatorKeyFile>
<CopyLocalLockFileAssemblies>false</CopyLocalLockFileAssemblies>
<CopyLocalLockFileAssemblies Condition="'$(TargetFramework)' == 'netcoreapp3.0'">false</CopyLocalLockFileAssemblies>
Copy link
Contributor

@harishsk harishsk Feb 20, 2020 •
edited by frank-dong-ms-zz
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought we set this to save on disk space. If we set this only for netcoreapp3.0 what happens to the diskspace usage on other platforms? #Resolved

Copy link
Contributor Author

@frank-dong-ms-zz frank-dong-ms-zz Feb 20, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, we only met disk issue on dotnet core 3.0 because of below setting from build tools:

false

false

true

for dotnet core 3.0 packages will copy to output folder by default and use extra 6-7 GB. So I set here to not copy packages to output, but this setting to false somehow affect test running for netfx 461 as below:
https://dev.azure.com/dnceng/public/_build/results?buildId=528701&view=logs&j=32952595-30e7-56fa-9b86-c4579b87f5d1

I'm not fully understand why this setting will affect test running on CI for netfx 461 as xunit seems not able to find any test to run but restrict this setting only for dotnet core 3.0 fix the disk issue also allow netfx 461 test to run on CI

In reply to: 382258052 [](ancestors = 382258052)

</PropertyGroup>

<ItemGroup>
Expand Down