Skip to content

Conversation

@Ivanidzo4ka
Copy link
Contributor

It's nice to not have spaces in the end of lines

@Ivanidzo4ka
Copy link
Contributor Author

@zeahmed @sfilipi Robotom is really unhappy with spaces in the end of line, so if you don't mind I would pacify it :)

public const string UserNameValue = "FastTree (Boosted Trees) Tweedie Regression";
public const string Summary = "Trains gradient boosted decision trees to fit target values using a Tweedie loss function. This learner is a generalization of Poisson, compound Poisson, and gamma regression.";
new public const string Remarks = @"<remarks>
public new const string Remarks = @"<remarks>
Copy link
Contributor

@zeahmed zeahmed Jul 2, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Following the documentation, I see that keyword new is the first in statements. #Resolved

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me add real @TomFinley
RoboTom gives this:
warning TLC_ExplicitAccessModifiers: Symbol 'Remarks' did not have access modifiers as the leading modifiers

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The cold robotic hand of robotom was not programmed for this eventuality, due to the limitations of its flawed, human, designer. I might prefer to change robotom vs. do this.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reverted. thank you for bringing this up Zeeshan!


In reply to: 199651709 [](ancestors = 199651709)

Copy link
Member

@sfilipi sfilipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

Copy link
Contributor

@TomFinley TomFinley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@TomFinley TomFinley merged commit 5bbf7cf into dotnet:master Jul 3, 2018
internal const string ShortName = "PR";
internal const string Summary = "Poisson Regression assumes the unknown function, denoted Y has a Poisson distribution.";
new internal const string Remarks = @"<remarks>
internal new const string Remarks = @"<remarks>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Ivanidzo4ka, It has be reverted here as well...:)
I have opened PR (486) to fix it.

eerhardt pushed a commit to eerhardt/machinelearning that referenced this pull request Jul 27, 2018
* remove all spaces in the end of lines
@ghost ghost locked as resolved and limited conversation to collaborators Mar 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants