Skip to content

Remove incorrectly-coded finalizer in DnnRetrainTransformer #4754

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 1, 2020
Merged

Remove incorrectly-coded finalizer in DnnRetrainTransformer #4754

merged 1 commit into from
Feb 1, 2020

Conversation

@sharwell
Copy link
Contributor

@sharwell sharwell commented Jan 31, 2020

Extracted from #4569

@sharwell sharwell requested a review from a team as a code owner January 31, 2020 19:44
frank-dong-ms-zz
frank-dong-ms-zz approved these changes Jan 31, 2020
View reviewed changes
Copy link
Contributor

@frank-dong-ms-zz frank-dong-ms-zz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@sharwell sharwell merged commit 90df4e0 into dotnet:master Feb 1, 2020
@sharwell sharwell deleted the rm-finalizer branch February 1, 2020 21:43
@ghost ghost locked as resolved and limited conversation to collaborators Mar 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@harishsk harishsk harishsk approved these changes

@frank-dong-ms-zz frank-dong-ms-zz frank-dong-ms-zz approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sharwell @harishsk @frank-dong-ms-zz