separate build pipelines #4688
Merged
separate build pipelines #4688
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
frank-dong-ms-zz
commented
Jan 22, 2020
frank-dong-ms-zz
commented
- new outer loop pipeline that runs all tests
- remove flaky tests from CI
Codecov Report
@@ Coverage Diff @@
## master #4688 +/- ##
=========================================
Coverage ? 75.81%
=========================================
Files ? 951
Lines ? 172437
Branches ? 18616
=========================================
Hits ? 130727
Misses ? 36538
Partials ? 5172
|
frank-dong-ms-zz
requested review from
codemzs,
eerhardt,
harishsk,
safern and
sharwell
Contributor
Author
|
This is the CI build for latest iteration: https://dev.azure.com/dnceng/public/_build/results?buildId=493381&view=results |
harishsk
reviewed
Jan 23, 2020
|
|
||
| [RetryFact] | ||
| #if INNER_LOOP | ||
| [Fact(Skip = "skip due to flaky")] |
Contributor
There was a problem hiding this comment.
Can you please change the message to something like "Skipping test temporarily. This test will be re-enabled once the cause of failures has been determined"
harishsk
reviewed
Jan 23, 2020
| } | ||
| } | ||
|
|
||
| #if INNER_LOOP |
Contributor
There was a problem hiding this comment.
Can you please investigate whether is possible to skip the test at runtime instead of disabling it at compile time?
harishsk
approved these changes
Jan 27, 2020
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.