Skip to content

Conversation

@eerhardt
Copy link
Member

OnnxRuntime supports win-x86, so start running tests on the win-x86 leg.

OnnxRuntime supports win-x86, so start running tests on the win-x86 leg.
@eerhardt eerhardt requested review from a team and harishsk October 15, 2019 14:21
@codecov
Copy link

codecov bot commented Oct 15, 2019

Codecov Report

Merging #4337 into master will decrease coverage by 0.02%.
The diff coverage is 83.33%.

@@            Coverage Diff             @@
##           master    #4337      +/-   ##
==========================================
- Coverage   74.58%   74.55%   -0.03%     
==========================================
  Files         879      879              
  Lines      154524   154527       +3     
  Branches    16883    16882       -1     
==========================================
- Hits       115249   115206      -43     
- Misses      34526    34576      +50     
+ Partials     4749     4745       -4
Flag Coverage Δ
#Debug 74.55% <83.33%> (-0.03%) ⬇️
#production 70.12% <ø> (-0.04%) ⬇️
#test 89.55% <83.33%> (ø) ⬆️
Impacted Files Coverage Δ
test/Microsoft.ML.Tests/OnnxConversionTest.cs 94.17% <100%> (+0.14%) ⬆️
...t.ML.TestFramework/Attributes/OnnxFactAttribute.cs 88.88% <80%> (+5.55%) ⬆️
...c/Microsoft.ML.FastTree/Utils/ThreadTaskManager.cs 79.48% <0%> (-20.52%) ⬇️
src/Microsoft.ML.AutoML/Sweepers/ISweeper.cs 59.49% <0%> (-7.6%) ⬇️
src/Microsoft.ML.Core/Data/ProgressReporter.cs 70.95% <0%> (-6.99%) ⬇️
src/Microsoft.ML.AutoML/Sweepers/Parameters.cs 77.96% <0%> (-5.94%) ⬇️
....ML.AutoML/PipelineSuggesters/PipelineSuggester.cs 83.19% <0%> (-3.37%) ⬇️
...L.AutoML/TrainerExtensions/TrainerExtensionUtil.cs 87.32% <0%> (+1.87%) ⬆️

Copy link
Contributor

@harishsk harishsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🕐

@eerhardt eerhardt requested a review from harishsk October 15, 2019 16:43
Copy link
Contributor

@harishsk harishsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@eerhardt
Copy link
Member Author

It looks like with this change our CI machines are bumping against the storage limit:

D:\a\1\s\Tools\dotnetcli\sdk\3.0.100-preview9-014004\Sdks\NuGet.Build.Tasks.Pack\build\NuGet.Build.Tasks.Pack.targets(198,5): error : There is not enough space on the disk. : 'D:\a\1\s\bin\packages\Microsoft.ML.symbols.1.4.0-preview3-28215-0.nupkg' [D:\a\1\s\pkg\Microsoft.ML\Microsoft.ML.symbols.nupkgproj]

@chcosta - is there any way to request more storage on the hosted machines?

I guess another option would be to clean up some space after we publish the test results, and before we build the NuGet packages.

@eerhardt
Copy link
Member Author

I cleaned up some space with #4338, which is allowing this PR to go through now.

@eerhardt eerhardt merged commit d871655 into dotnet:master Oct 17, 2019
@eerhardt eerhardt deleted the UpdateOnnx branch October 17, 2019 18:09
frank-dong-ms-zz pushed a commit to frank-dong-ms-zz/machinelearning that referenced this pull request Nov 4, 2019
* Update OnnxRuntime to latest version.

OnnxRuntime supports win-x86, so start running tests on the win-x86 leg.

* Update README - ONNX is supported on 32-bit.

* Consolidate "is onnx runtime supported" logic in the tests.
@ghost ghost locked as resolved and limited conversation to collaborators Mar 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants