Build fix - removing the BOM from the CMakeLists.txt file #430
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… unecessary cmake version requirement
shauheen
approved these changes
Jun 27, 2018
TomFinley
approved these changes
Jun 27, 2018
Contributor
TomFinley
left a comment
TomFinley
left a comment
There was a problem hiding this comment.
Thanks @sfilipi ... I know there are some reasons why BOMs are not totally useless around different cultural interpretations of non-BOMed files, but they're more trouble than they're worth. I wonder if there's a way to configure git to not BOM the files, just as there's a way to handle the unix/windows line endings.
eerhardt
pushed a commit
that referenced
this pull request
Jun 27, 2018
eerhardt
pushed a commit
to eerhardt/machinelearning
that referenced
this pull request
Jul 27, 2018
* removing extraneous character that broke the linux build, and with it unecessary cmake version requirement * Removing the BOM from the file
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the BOM from the CMakeLists.txt file, since it is breaking the build in vsts.