Reformatted Ranking samples to width 85 #3930
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
natke
reviewed
Jun 28, 2019
Contributor
natke
left a comment
natke
left a comment
There was a problem hiding this comment.
Looks like there is extra whitespace in many of the comments
| // <a href="https://www.nuget.org/packages/Microsoft.ML.FastTree/">Microsoft.ML.FastTree</a>. | ||
| // This example requires installation of additional NuGet package for | ||
| // Microsoft.ML.FastTree at | ||
| // https://www.nuget.org/packages/Microsoft.ML.FastTree/ |
Contributor
Author
There was a problem hiding this comment.
Fixed in new commit
Contributor
Author
There was a problem hiding this comment.
Fixed in new commit.
|
|
||
| // Convert the list of data points to an IDataView object, which is consumable by ML.NET API. | ||
| // Convert the list of data points to an IDataView object, which is | ||
| // consumable by ML.NET API. |
Contributor
Author
There was a problem hiding this comment.
Fixed in new commit.
natke
reviewed
Jun 28, 2019
| // Label: 4, Score: -2.168355 | ||
| // Label: 1, Score: -3.074823 | ||
| // Label: 1, Score: -1.523607 | ||
| // Label: 5, Score: 2.493263 |
Contributor
There was a problem hiding this comment.
Did these numbers change for the sample?
Contributor
Author
There was a problem hiding this comment.
Yeah they must have changed from a more recent pull.
Contributor
There was a problem hiding this comment.
Ok, I see that the sample is using random data points. Thanks
natke
approved these changes
Jun 29, 2019
wschin
approved these changes
Jul 1, 2019
wschin
reviewed
Jul 1, 2019
| /// | ||
| /// <param name="bias">The bias, or offset, in the calculation of the label. | ||
| /// </param> | ||
| /// |
Contributor
Author
There was a problem hiding this comment.
I think for lines 93-105, the empty lines were there originally. Would you like me to get rid of them?
Dmitry-A
pushed a commit
to Dmitry-A/machinelearning
that referenced
this pull request
Jul 24, 2019
* Reformatted Ranking samples to width 85 * Fixed syntax errors * Removed extra white spaces * Spacing changes * Spacing changes * Spacing changes * Spacing changes * Spacing changes * Spacing changes * Spacing changes
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Guidelines followed:
Fix for Issue #3478