Bugfix/hardwired sigmoid #3850
Merged
Bugfix/hardwired sigmoid #3850
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…f Microsoft.ML.StandardTrainers
|
|
artidoro
reviewed
Jun 10, 2019
Contributor
artidoro
left a comment
artidoro
left a comment
There was a problem hiding this comment.
A few minor comments but it's almost good to go!
Member
|
Thanks a lot for contributing this fix! Would you consider making a direct test between ML.NET and LightGBM using non-default sigmoid? We have a similar test here. |
Contributor
Author
|
Thanks for your feedback @wschin ! I added a positive and negative test case for the case you mentioned. |
wschin
reviewed
Jun 11, 2019
wschin
reviewed
Jun 11, 2019
wschin
reviewed
Jun 11, 2019
wschin
reviewed
Jun 11, 2019
wschin
reviewed
Jun 11, 2019
wschin
approved these changes
Jun 11, 2019
Member
wschin
left a comment
wschin
left a comment
There was a problem hiding this comment.
Overall LGTM. Just some minor comments. :)
Co-Authored-By: Wei-Sheng Chin <[email protected]>
Co-Authored-By: Wei-Sheng Chin <[email protected]>
Co-Authored-By: Wei-Sheng Chin <[email protected]>
artidoro
approved these changes
Jun 12, 2019
codemzs
added a commit
to codemzs/machinelearning
that referenced
this pull request
Jul 3, 2019
This reverts commit 6722dbf. # Conflicts: # test/Microsoft.ML.Tests/TrainerEstimators/TreeEstimators.cs
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1422
Fixes the Hardcoded Sigmoid value from -.5 to the value specified during training.
Let Microsoft.ML.Tests see internals of Microsoft.ML.Standard trainers to access trained model parameters for testing verification.