Skip to content

Conversation

@Ivanidzo4ka
Copy link
Contributor

@Ivanidzo4ka Ivanidzo4ka commented Apr 24, 2019

Copy of #3552

Fixes the typos documented in #3491
Changes ngram -> n-gram

Created by me because previous PR got stuck in builds.

Copy link
Member

@sfilipi sfilipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@Ivanidzo4ka Ivanidzo4ka requested a review from shmoradims April 24, 2019 21:11
internal sealed class Column : ManyToOneColumn
{
[Argument(ArgumentType.AtMostOnce, HelpText = "Maximum ngram length", ShortName = "ngram")]
[Argument(ArgumentType.AtMostOnce, HelpText = "Maximum n-gram length", ShortName = "n-gram")]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"n-gram" [](start = 95, length = 8)

fixing

@sfilipi
Copy link
Member

sfilipi commented Apr 24, 2019

try closing and opening

@sfilipi sfilipi closed this Apr 24, 2019
@sfilipi sfilipi reopened this Apr 24, 2019
@Ivanidzo4ka Ivanidzo4ka reopened this Apr 25, 2019
@Ivanidzo4ka Ivanidzo4ka reopened this Apr 25, 2019
@shmoradims shmoradims merged commit e3c2043 into dotnet:master Apr 25, 2019
@ghost ghost locked as resolved and limited conversation to collaborators Mar 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants