Skip to content

Conversation

@TomFinley
Copy link
Contributor

Fix of PR #3288. Shauheen had a couple comments that I had addressed and committed locally, but did not get pushed successfully to the branch of that PR... sorry about that @shauheen!

@codecov
Copy link

codecov bot commented Apr 11, 2019

Codecov Report

Merging #3296 into master will increase coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3296      +/-   ##
==========================================
+ Coverage   72.63%   72.63%   +<.01%     
==========================================
  Files         807      807              
  Lines      145127   145127              
  Branches    16219    16219              
==========================================
+ Hits       105410   105413       +3     
+ Misses      35299    35297       -2     
+ Partials     4418     4417       -1
Flag Coverage Δ
#Debug 72.63% <ø> (ø) ⬆️
#production 68.17% <ø> (ø) ⬆️
#test 88.94% <ø> (ø) ⬆️
Impacted Files Coverage Δ
src/Microsoft.ML.DataView/VectorType.cs 89.41% <ø> (ø) ⬆️
...soft.ML.Data/DataLoadSave/Text/TextLoaderCursor.cs 84.7% <0%> (-0.41%) ⬇️
...StandardTrainers/Standard/LinearModelParameters.cs 60.31% <0%> (+0.26%) ⬆️
src/Microsoft.ML.Transforms/Text/LdaTransform.cs 89.89% <0%> (+0.62%) ⬆️

1 similar comment
@codecov
Copy link

codecov bot commented Apr 11, 2019

Codecov Report

Merging #3296 into master will increase coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3296      +/-   ##
==========================================
+ Coverage   72.63%   72.63%   +<.01%     
==========================================
  Files         807      807              
  Lines      145127   145127              
  Branches    16219    16219              
==========================================
+ Hits       105410   105413       +3     
+ Misses      35299    35297       -2     
+ Partials     4418     4417       -1
Flag Coverage Δ
#Debug 72.63% <ø> (ø) ⬆️
#production 68.17% <ø> (ø) ⬆️
#test 88.94% <ø> (ø) ⬆️
Impacted Files Coverage Δ
src/Microsoft.ML.DataView/VectorType.cs 89.41% <ø> (ø) ⬆️
...soft.ML.Data/DataLoadSave/Text/TextLoaderCursor.cs 84.7% <0%> (-0.41%) ⬇️
...StandardTrainers/Standard/LinearModelParameters.cs 60.31% <0%> (+0.26%) ⬆️
src/Microsoft.ML.Transforms/Text/LdaTransform.cs 89.89% <0%> (+0.62%) ⬆️

@TomFinley TomFinley merged commit 43d4c18 into dotnet:master Apr 12, 2019
@TomFinley TomFinley deleted the DocDataView2 branch April 12, 2019 18:09
TomFinley added a commit to TomFinley/machinelearning that referenced this pull request Apr 12, 2019
@ghost ghost locked as resolved and limited conversation to collaborators Mar 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants