Skip to content

Prior trainer should accept label column type of boolean ONLY. #3291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 11, 2019
Merged

Prior trainer should accept label column type of boolean ONLY. #3291

merged 1 commit into from
Apr 11, 2019

Conversation

@codemzs
Copy link
Member

@codemzs codemzs commented Apr 11, 2019

fixes #3119

TomFinley
TomFinley approved these changes Apr 11, 2019
View reviewed changes
Copy link
Contributor

@TomFinley TomFinley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @codemzs !

@codecov
Copy link

codecov bot commented Apr 11, 2019

Codecov Report

Merging #3291 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #3291      +/-   ##
==========================================
+ Coverage   72.63%   72.63%   +<.01%     
==========================================
  Files         807      807              
  Lines      145129   145127       -2     
  Branches    16220    16219       -1     
==========================================
  Hits       105413   105413              
+ Misses      35298    35296       -2     
  Partials     4418     4418
Flag Coverage Δ
#Debug 72.63% <100%> (ø) ⬆️
#production 68.17% <100%> (ø) ⬆️
#test 88.94% <100%> (-0.01%) ⬇️
Impacted Files Coverage Δ
...oft.ML.Tests/TrainerEstimators/PriorRandomTests.cs 100% <100%> (ø) ⬆️
...est/Microsoft.ML.Predictor.Tests/TestPredictors.cs 63.76% <100%> (-0.04%) ⬇️
...StandardTrainers/Standard/Simple/SimpleTrainers.cs 77.61% <100%> (-0.17%) ⬇️
src/Microsoft.ML.Maml/MAML.cs 24.75% <0%> (-1.46%) ⬇️
...soft.ML.Data/DataLoadSave/Text/TextLoaderCursor.cs 84.9% <0%> (+0.2%) ⬆️
src/Microsoft.ML.Transforms/Text/LdaTransform.cs 89.89% <0%> (+0.62%) ⬆️

1 similar comment
@codecov
Copy link

codecov bot commented Apr 11, 2019

Codecov Report

Merging #3291 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #3291      +/-   ##
==========================================
+ Coverage   72.63%   72.63%   +<.01%     
==========================================
  Files         807      807              
  Lines      145129   145127       -2     
  Branches    16220    16219       -1     
==========================================
  Hits       105413   105413              
+ Misses      35298    35296       -2     
  Partials     4418     4418
Flag Coverage Δ
#Debug 72.63% <100%> (ø) ⬆️
#production 68.17% <100%> (ø) ⬆️
#test 88.94% <100%> (-0.01%) ⬇️
Impacted Files Coverage Δ
...oft.ML.Tests/TrainerEstimators/PriorRandomTests.cs 100% <100%> (ø) ⬆️
...est/Microsoft.ML.Predictor.Tests/TestPredictors.cs 63.76% <100%> (-0.04%) ⬇️
...StandardTrainers/Standard/Simple/SimpleTrainers.cs 77.61% <100%> (-0.17%) ⬇️
src/Microsoft.ML.Maml/MAML.cs 24.75% <0%> (-1.46%) ⬇️
...soft.ML.Data/DataLoadSave/Text/TextLoaderCursor.cs 84.9% <0%> (+0.2%) ⬆️
src/Microsoft.ML.Transforms/Text/LdaTransform.cs 89.89% <0%> (+0.62%) ⬆️

@codemzs codemzs merged commit bf4d605 into dotnet:master Apr 11, 2019
codemzs added a commit to codemzs/machinelearning that referenced this pull request Apr 11, 2019
@codemzs
Prior trainer should accept label column type of boolean ONLY. (dotne…
e58707f 
…t#3291)
@codemzs codemzs mentioned this pull request Apr 11, 2019
Closed
@ghost ghost locked as resolved and limited conversation to collaborators Mar 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@eerhardt eerhardt Awaiting requested review from eerhardt

@artidoro artidoro Awaiting requested review from artidoro

2 more reviewers

@wschin wschin wschin approved these changes

@TomFinley TomFinley TomFinley approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Prior binary trainer requires float label column, but all other binary trainers require bool

3 participants

@codemzs @wschin @TomFinley