Skip to content

Conversation

@tauheedul
Copy link
Contributor

@tauheedul tauheedul commented Apr 11, 2019

Added reference to ML Cookbook, Roadmap, API Reference Doc, Samples and related Infer.NET and NimbusML Repo Docs

We are excited to review your PR.

So we can do the best job, please check:

  • There's a descriptive title that will make sense to other developers some time from now.
  • There's associated issues. All PR's should have issue(s) associated - unless a trivial self-evident change such as fixing a typo. You can use the format Fixes #nnnn in your description to cause GitHub to automatically close the issue(s) when your PR is merged.
  • Your change description explains what the change does, why you chose your approach, and anything else that reviewers should know.
  • You have included any necessary tests in the same PR.

Added reference to ML Cookbook, Roadmap, API Reference Doc, Samples and related Infer.NET and NimbusML Repo Docs
@codecov
Copy link

codecov bot commented Apr 11, 2019

Codecov Report

Merging #3289 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #3289   +/-   ##
=======================================
  Coverage   72.63%   72.63%           
=======================================
  Files         807      807           
  Lines      145129   145129           
  Branches    16220    16220           
=======================================
  Hits       105415   105415           
- Misses      35296    35297    +1     
+ Partials     4418     4417    -1
Flag Coverage Δ
#Debug 72.63% <ø> (ø) ⬆️
#production 68.17% <ø> (ø) ⬆️
#test 88.94% <ø> (ø) ⬆️
Impacted Files Coverage Δ
...soft.ML.Data/DataLoadSave/Text/TextLoaderCursor.cs 84.7% <0%> (-0.21%) ⬇️
...ML.Transforms/Text/StopWordsRemovingTransformer.cs 86.26% <0%> (+0.15%) ⬆️

Copy link
Member

@eerhardt eerhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks!

@eerhardt eerhardt requested review from glebuk and shauheen April 11, 2019 15:33
@shauheen shauheen merged commit c601b77 into dotnet:master Apr 11, 2019
@ghost ghost locked as resolved and limited conversation to collaborators Mar 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants