Skip to content

Multi-column mapping API for normalizer estimators. #3172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Apr 3, 2019
Merged

Multi-column mapping API for normalizer estimators. #3172

merged 8 commits into from
Apr 3, 2019

Conversation

@codemzs
Copy link
Member

@codemzs codemzs commented Apr 2, 2019

fixes #3171

@codecov
Copy link

codecov bot commented Apr 2, 2019 •
edited by codemzs
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@fde1ab7). Click here to learn what that means.
The diff coverage is 0%.

@@            Coverage Diff            @@
##             master    #3172   +/-   ##
=========================================
  Coverage          ?   72.52%           
=========================================
  Files             ?      807           
  Lines             ?   144790           
  Branches          ?    16208           
=========================================
  Hits              ?   105014           
  Misses            ?    35360           
  Partials          ?     4416
Flag Coverage Δ
#Debug 72.52% <0%> (?)
#production 68.11% <0%> (?)
#test 88.82% <ø> (?)
Impacted Files Coverage Δ
src/Microsoft.ML.Transforms/NormalizerCatalog.cs 50% <0%> (ø)
#Resolved

@codecov
Copy link

codecov bot commented Apr 2, 2019 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@fde1ab7). Click here to learn what that means.
The diff coverage is 100%.

@@            Coverage Diff            @@
##             master    #3172   +/-   ##
=========================================
  Coverage          ?   72.56%           
=========================================
  Files             ?      807           
  Lines             ?   144938           
  Branches          ?    16208           
=========================================
  Hits              ?   105181           
  Misses            ?    35343           
  Partials          ?     4414
Flag Coverage Δ
#Debug 72.56% <100%> (?)
#production 68.13% <100%> (?)
#test 88.88% <100%> (?)
Impacted Files Coverage Δ
src/Microsoft.ML.Transforms/NormalizerCatalog.cs 84.78% <100%> (ø)
...Microsoft.ML.Tests/Transformers/NormalizerTests.cs 100% <100%> (ø)

eerhardt
eerhardt reviewed Apr 2, 2019
View reviewed changes
@eerhardt
Copy link
Member

eerhardt commented Apr 2, 2019 •
edited by codemzs
Loading

Can we add some tests for the new APIs? #Resolved

eerhardt
eerhardt reviewed Apr 2, 2019
View reviewed changes
eerhardt
eerhardt reviewed Apr 2, 2019
View reviewed changes
eerhardt
eerhardt reviewed Apr 2, 2019
View reviewed changes
eerhardt
eerhardt approved these changes Apr 2, 2019
View reviewed changes
Copy link
Member

@eerhardt eerhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. thanks!

wschin
wschin reviewed Apr 2, 2019
View reviewed changes
wschin
wschin reviewed Apr 3, 2019
View reviewed changes
@codemzs codemzs merged commit a7bcdda into dotnet:master Apr 3, 2019
codemzs added a commit to codemzs/machinelearning that referenced this pull request Apr 11, 2019
@codemzs
Multi-column mapping API for normalizer estimators. (dotnet#3172)
bed90c6 
* Multi-column mapping for Normalizer estimators.

* XML comment.

* revert Program.cs

* Add copyright header.

* Add tests.

* PR feedback.

* cleanup.

* PR feedback.
@codemzs codemzs mentioned this pull request Apr 11, 2019
Closed
@ghost ghost locked as resolved and limited conversation to collaborators Mar 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@eerhardt eerhardt eerhardt approved these changes

@sfilipi sfilipi Awaiting requested review from sfilipi

@TomFinley TomFinley Awaiting requested review from TomFinley

@artidoro artidoro Awaiting requested review from artidoro

+1 more reviewer

@wschin wschin wschin approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Multi-column mapping API for normalizer estimators.

3 participants

@codemzs @eerhardt @wschin