Skip to content

Conversation

@shauheen
Copy link
Contributor

@shauheen shauheen commented Apr 1, 2019

fixes #2244 yet AGAIN!

@shauheen shauheen requested review from eerhardt and glebuk April 1, 2019 20:49
@codecov
Copy link

codecov bot commented Apr 1, 2019

Codecov Report

Merging #3157 into master will increase coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3157      +/-   ##
==========================================
+ Coverage   72.53%   72.53%   +<.01%     
==========================================
  Files         808      808              
  Lines      144740   144740              
  Branches    16202    16202              
==========================================
+ Hits       104987   104988       +1     
+ Misses      35343    35342       -1     
  Partials     4410     4410
Flag Coverage Δ
#Debug 72.53% <ø> (ø) ⬆️
#production 68.12% <ø> (ø) ⬆️
#test 88.82% <ø> (ø) ⬆️
Impacted Files Coverage Δ
...StandardTrainers/Standard/LinearModelParameters.cs 60.05% <0%> (-0.27%) ⬇️
...ML.Transforms/Text/StopWordsRemovingTransformer.cs 86.26% <0%> (+0.15%) ⬆️
...soft.ML.Data/DataLoadSave/Text/TextLoaderCursor.cs 84.9% <0%> (+0.2%) ⬆️

1 similar comment
@codecov
Copy link

codecov bot commented Apr 1, 2019

Codecov Report

Merging #3157 into master will increase coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3157      +/-   ##
==========================================
+ Coverage   72.53%   72.53%   +<.01%     
==========================================
  Files         808      808              
  Lines      144740   144740              
  Branches    16202    16202              
==========================================
+ Hits       104987   104988       +1     
+ Misses      35343    35342       -1     
  Partials     4410     4410
Flag Coverage Δ
#Debug 72.53% <ø> (ø) ⬆️
#production 68.12% <ø> (ø) ⬆️
#test 88.82% <ø> (ø) ⬆️
Impacted Files Coverage Δ
...StandardTrainers/Standard/LinearModelParameters.cs 60.05% <0%> (-0.27%) ⬇️
...ML.Transforms/Text/StopWordsRemovingTransformer.cs 86.26% <0%> (+0.15%) ⬆️
...soft.ML.Data/DataLoadSave/Text/TextLoaderCursor.cs 84.9% <0%> (+0.2%) ⬆️

Copy link
Contributor

@glebuk glebuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@eerhardt eerhardt merged commit 0ce5618 into dotnet:master Apr 2, 2019
@shauheen shauheen deleted the fix_build branch April 2, 2019 17:19
shauheen added a commit to shauheen/machinelearning that referenced this pull request Apr 2, 2019
@ghost ghost locked as resolved and limited conversation to collaborators Mar 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Official builds are broken because myget is full

3 participants